Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telemetry] add protobuf for upstream DNS metrics #2142

Merged
merged 2 commits into from
Jan 9, 2024
Merged

[telemetry] add protobuf for upstream DNS metrics #2142

merged 2 commits into from
Jan 9, 2024

Conversation

sherysheng
Copy link
Contributor

Add the counters of queries, responses, failures handled by upstream DNS server

@sherysheng sherysheng requested a review from jwhui January 4, 2024 03:06
@sherysheng
Copy link
Contributor Author

Depends-on openthread/openthread#9729

erjiaqing
erjiaqing approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@erjiaqing erjiaqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Irving-cl
Irving-cl approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sherysheng sherysheng removed the request for review from abtink January 9, 2024 04:49
abtink
abtink approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwhui jwhui merged commit 4c3d907 into openthread:main Jan 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erjiaqing erjiaqing erjiaqing approved these changes

@Irving-cl Irving-cl Irving-cl approved these changes

@jwhui jwhui jwhui approved these changes

@abtink abtink abtink approved these changes

@morningboata morningboata morningboata approved these changes

Assignees
No one assigned
Labels
comp: dns comp: telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sherysheng @erjiaqing @Irving-cl @jwhui @abtink @morningboata