adr: default kas keys for platform #2121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
reviewed
Apr 28, 2025
jakedoublev
reviewed
Apr 28, 2025
Comment on lines
109
to
114
| | Column | type | | ||
| | ------- | ------------- | | ||
| | id | uuid (string) | | ||
| | key_id | string | | ||
| | ..... | ..... | | ||
| | default | bool | |
There was a problem hiding this comment.
Is this documenting the change to the new asymmetric keys table?
There was a problem hiding this comment.
Yeah and maybe I should just remove this because it gets into implementation details.
jakedoublev
reviewed
Apr 28, 2025
| | key_id | string | | ||
| | ..... | ..... | | ||
| | default | bool | | ||
|
|
There was a problem hiding this comment.
Suggested change
| The default key and KAS for ZTDF and NanoTDF served by the well-known configuration will be a combination of policy and config (dependent on the in-flight Key Management work). | |
| The config will specify the `kid` for each key and the public... |
Do you think we should have the well-known config for the default KAS point to one of the registered KASes in policy, which would have the added benefit of ensuring the well-known KAS uri has been allowListed?
There was a problem hiding this comment.
That would be the idea if we added a default bool column to the kas keys table. This way on startup we can pull that info automatically and add it to wellknown.
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
b-long
reviewed
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Testing Instructions