Skip to content

Bump cryptography from 43.0.1 to 44.0.1 in /pytest-selenium #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@
"flat": "~5.0",
"focus-within-polyfill": "^5.2.1",
"history": "4.7.2",
"html-entities": "^2.3.5",
"js-cookie": "~2.2",
"lodash": "^4.17.21",
"mdn-polyfills": "^5.20.0",
"mime": "^3.0.0",
"path-to-regexp": "<4",
"prop-types": "^15.8.1",
"query-string": "~6.2",
"quick-lru": "^4.0.1",
"rangy": "^1.3.1",
Expand All @@ -38,12 +36,10 @@
"redux": "4.0.1",
"reselect": "4.0.0",
"scroll-to-element": "^2.0.3",
"stacktrace-js": "~2.0",
"styled-components": "^4",
"styled-icons": "^9",
"typesafe-actions": "^4.4.2",
"typescript": "^4",
"url": "^0.11.0",
"uuid": "~7.0",
"weak-map": "^1.0.8",
"workbox-core": "^7.0.0",
Expand Down Expand Up @@ -108,9 +104,6 @@
"@aws-sdk/client-sqs": "<3.567.0",
"@aws-sdk/credential-providers": "<3.567.0",
"@babel/core": "^7.22.5",
"@babel/plugin-proposal-class-properties": "^7.1.0",
"@babel/plugin-proposal-object-rest-spread": "^7.0.0",
"@babel/plugin-proposal-optional-chaining": "^7.13.12",
"@babel/plugin-transform-runtime": "^7.22.5",
"@babel/preset-env": "^7.22.5",
"@babel/preset-react": "7.22.5",
Expand Down Expand Up @@ -138,15 +131,11 @@
"@types/react-loadable": "~5.5",
"@types/react-redux": "~7.1",
"@types/react-test-renderer": "~16.9",
"@types/semver-sort": "~0.0",
"@types/serve-static": "~1.15",
"@types/stacktrace-js": "~2.0",
"@types/styled-components": "~4.1",
"@types/tiny-async-pool": "~1.0",
"@types/uuid": "~7.0",
"@types/yargs": "~13.0",
"babel-core": "7.0.0-bridge.0",
"babel-plugin-transform-dynamic-import": "^2.1.0",
"codecov": "^3.8.3",
"date-fns": "^2.30.0",
"date-fns-tz": "^2.0.0",
Expand All @@ -162,14 +151,12 @@
"node-fetch": "~2.6",
"pify": "^4.0.1",
"portfinder": "^1.0.32",
"prettier": "1.19.1",
"pretty": "^2.0.0",
"progress": "^2.0.3",
"puppeteer": "^5",
"react-scripts": "^4.0.3",
"react-test-renderer": "~16.9",
"resize-observer-polyfill": "^1.5.1",
"semver-sort": "~0.0",
"serve-static": "~1.16",
"sitemap": "<4",
"source-map-explorer": "^2.5.3",
Expand All @@ -178,7 +165,6 @@
"stylelint-config-styled-components": "^0.1.1",
"stylelint-processor-styled-components": "^1.5.2",
"tiny-async-pool": "~1.0",
"ts-unused-exports": "<7",
"tslint": "6.1.3",
"yargs": "~13.2"
},
Expand Down
2 changes: 1 addition & 1 deletion pytest-selenium/requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cffi==1.15.0
cfgv==3.3.1
chardet==4.0.0
chromedriver-binary==126.0.6478.62.0
cryptography==43.0.1
cryptography==44.0.1
Faker==13.3.4
identify==2.4.12
idna==3.7 # pyup: ignore
Expand Down
4 changes: 0 additions & 4 deletions src/babel-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,7 @@ module.exports = function(additionalExtensions = ['.ts', '.tsx']) {
],
plugins: [
'macros',
'@babel/plugin-proposal-object-rest-spread',
'@babel/plugin-proposal-class-properties',
'@babel/plugin-proposal-optional-chaining',
'@babel/transform-runtime',
'babel-plugin-transform-dynamic-import',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm like... pretty sure you can't just remove these. doesn't the static site render fail without them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, these were the ones that seemed the most likely to be a problem to me. All the CI tests passed, but I didn't know what I might be missing.
The prerender tests also run as expected. Should that catch it if it's a static site problem? Maybe updates to other @babel packages made this no longer necessary? Is there something else I should be checking?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel-plugin-transform-dynamic-import should not be used with a bundler according to the docs. Webpack handles dynamic import.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin-proposals were added during some upgrades years ago and have been included in @babel-preset since 2020.

]
});
};
Loading
Loading