Stop checking for duplicates in imports #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status quo data imports always fail if there is one or more duplicate items yielded by the scraper. Ideally scrapes do not emit duplicates, but due to the vagaries of our source sites, it can be time consuming in some cases to root them out. And in many cases the duplicates are identical, so doing extra imports of the same data does not cause harm. In those cases, eliminating the duplicates is actually pretty low priority work. But the fact that the import is halted turns it into high priority work.
This change introduces a runtime flag
--allow_duplicatesthat can be used to change the behavior to warn only on duplicate items.