Skip to content

Commit

Permalink
Stop validating repeat phone numbers on offices
Browse files Browse the repository at this point in the history
  • Loading branch information
jessemortenson committed Jan 24, 2024
1 parent 154ebaa commit 6609caa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions openstates/data/models/people_orgs.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,11 @@ def __str__(self):

OFFICE_CHOICES = (
("district", "District Office"),
("district-mail", "District Mailing Address")
("capitol", "Capitol Office"),
("capitol-mail", "Capitol Mailing Address")
("primary", "Primary Office"),
("home", "Home")
)


Expand Down
2 changes: 1 addition & 1 deletion openstates/utils/people/lint_people.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def validate_offices(person: Person) -> list[str]:
for office in person.offices:
type_counter[office.classification] += 1
for key, value in office.dict().items():
if key == "classification" or not value:
if key == "classification" or key == "voice" or key == "fax" or not value:
continue
# reverse lookup to see if we've used this phone number/etc. before
location_str = f"{office.classification} {key}"
Expand Down

0 comments on commit 6609caa

Please sign in to comment.