Change WatcherAPI deployment to a statefulset #59
+608
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cescgina
force-pushed
the
watcherapi_statefulset
branch
2 times, most recently
from
7967004 to
526c779
Compare
amoralej
reviewed
Feb 3, 2025
There was a problem hiding this comment.
+1 to add a scaling scenario for testing. Thanks!
In order to be consitent with the decision engine and applier, use an statefulset instead of a deployment for watcher-api. This change also modifies the config templates to ensure we don't rely on the root user at all, and run using either the watcher or apache users.
cescgina
force-pushed
the
watcherapi_statefulset
branch
from
526c779 to
cf93871
Compare
marios
reviewed
Feb 4, 2025
|
looks good @cescgina |
|
/lgtm thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be consistent with the decision engine and applier, use an
statefulset instead of a deployment for watcher-api. This change also
modifies the config templates to ensure we don't rely on the root user
at all, and run using either the watcher or apache users.
Related: OSPRH-13578