Add initial reconciler methods for WatcherApplier #49
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d138bcc07e3448f39e4d6ee65398da0c ✔️ noop SUCCESS in 0s |
viroel
force-pushed
the
applier_controller
branch
from
5c86430 to
6e60478
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
viroel
force-pushed
the
applier_controller
branch
from
6e60478 to
55bf155
Compare
viroel
force-pushed
the
applier_controller
branch
from
55bf155 to
1f49d2d
Compare
There was a problem hiding this comment.
Just a minor comment. Other than that, just add a base kuttl scenario for watcherapplier (new folder in https://github.com/openstack-k8s-operators/watcher-operator/tree/main/tests/kuttl/test-suites/default ) and it'd be ready to merge imo.
api/v1beta1/watcherapplier_types.go
Outdated
| // the openstack-operator in the top-level CR (e.g. the ContainerImage) | ||
| ObservedGeneration int64 `json:"observedGeneration,omitempty"` | ||
|
|
||
| // ReadyCount of watcher API instances |
There was a problem hiding this comment.
I wouldn't add ReadyCount until we create the deployment and can get the value.
There was a problem hiding this comment.
Yes, make sense, I commented out and add a TODO to add it back afterwards.
| ) | ||
|
|
||
| var _ = Describe("WatcherApplier controller with minimal spec values", func() { | ||
| When("A Watcher instance is created from minimal spec", func() { |
| ) | ||
| DeferCleanup(k8sClient.Delete, ctx, secret) | ||
| DeferCleanup(th.DeleteInstance, CreateWatcherApplier(watcherTest.WatcherApplier, GetDefaultWatcherApplierSpec())) | ||
| DeferCleanup(keystone.DeleteKeystoneAPI, keystone.CreateKeystoneAPI(watcherTest.WatcherApplier.Namespace)) |
There was a problem hiding this comment.
just a note that creating the KeystoneAPI here is not needed yet, since the WatcherApplier does not get it. It's ok to leave it anyway, since it will be needed for the next iteration
There was a problem hiding this comment.
correct, I removed since is not used at this moment, thanks!
Adds initial logic for reconciler on Watcher Applier controller, including inputs, serviceConfig and memcached configurations.
viroel
force-pushed
the
applier_controller
branch
from
1f49d2d to
fb418c3
Compare
viroel
changed the title
Adds initial logic for reconciler on Watcher Applier controller, including inputs, serviceConfig and memcached configurations.