-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test opendev watcher master content in CI job #39
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
378b1f4
to
8398c75
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1730a260e8344041aca6f62018345698 ✔️ openstack-meta-content-provider-master SUCCESS in 54m 56s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f87171ca6a324ee6af825ea0ba59de9b ✔️ openstack-meta-content-provider-master SUCCESS in 2h 15m 49s |
8398c75
to
8fab0d4
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/be9fe455e2d7496ababc7079b8311b8c ✔️ openstack-meta-content-provider-master SUCCESS in 2h 18m 44s |
b4b9fb6
to
4b637fb
Compare
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2658 is needed. |
recheck |
# Override zuul meta content provider provided content_provider_dlrn_md5_hash | ||
# var. As returned dlrn md5 hash comes from master release but job is using | ||
# antelope content. | ||
content_provider_dlrn_md5_hash: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(trying to understand)... is an alternative to doing this (false update_containers and hash set to '') perhaps to have a -antelope content provider instead of a master one here? or we don't want/need -antelope content provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal here is to always test openstack watcher content from master branch in master and antelope based EDPM job. watcher-operator-validation job is deploying using antelope content and watcher-operator should use openstack services container from meta content provider master.
That's why we donot want to use antelope content provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks its a bit clearer now and i also read the commit message but theres a few things going on here.
i'm still not clear why we need the content provider at all then in those cases we don't use the built containers from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we switched the default container images in the operator to use master since 5cf79ef if that helps.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/524b3ac564c747afb547af3e7cc3336d ✔️ openstack-meta-content-provider-master SUCCESS in 50m 42s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6425b0194e3343179c9ece4b28dcde08 ✔️ openstack-meta-content-provider-master SUCCESS in 53m 56s |
4b637fb
to
427418e
Compare
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2658 is needed. |
parent: podified-multinode-edpm-deployment-crc-2comp | ||
dependencies: ["openstack-meta-content-provider"] | ||
dependencies: ["openstack-meta-content-provider-master"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have the dependency at all then if we aren't going to use the built containers. do we need it for something else?
[edit]: maybe repos?
[edit][edit]: ah... operators https://github.com/openstack-k8s-operators/ci-framework/blob/affcd2a89dd04f6f5d0f6e64ddaf7b16b254ef10/roles/reproducer/templates/content-provider.yml.j2#L84
# Override zuul meta content provider provided content_provider_dlrn_md5_hash | ||
# var. As returned dlrn md5 hash comes from master release but job is using | ||
# antelope content. | ||
content_provider_dlrn_md5_hash: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks its a bit clearer now and i also read the commit message but theres a few things going on here.
i'm still not clear why we need the content provider at all then in those cases we don't use the built containers from it.
recheck |
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2658 is needed. |
recheck |
351b547
to
a23ced4
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6885467cbedd4835a295de1655606d5f ✔️ openstack-meta-content-provider-master SUCCESS in 1h 57m 24s |
a23ced4
to
aede059
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aec5f860a20e48ee9729c77bbbcb8c29 ✔️ openstack-meta-content-provider-master SUCCESS in 1h 59m 19s |
aede059
to
c9f4756
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/245575f9b3f9448ba4955958de1a638f ✔️ openstack-meta-content-provider-master SUCCESS in 2h 24m 32s |
c9f4756
to
012bc0e
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/424e39d501114e139a6150b0d71c37e2 ✔️ openstack-meta-content-provider-master SUCCESS in 2h 25m 39s |
012bc0e
to
737eb40
Compare
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2675 is needed. |
recheck |
1 similar comment
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/26d1e67be987441e819c1d353bf86f5a ✔️ openstack-meta-content-provider-master SUCCESS in 2h 18m 23s |
685ddbb
to
4f789a8
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/22866e54626f4875994827127e84474f ✔️ openstack-meta-content-provider-master SUCCESS in 55m 41s |
4f789a8
to
66335cd
Compare
290db06
to
59b79e9
Compare
recheck |
8c10862
to
d3bc83c
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0a6a9353dbdb451caad05a525f58d1bc ✔️ openstack-meta-content-provider-master SUCCESS in 2h 06m 45s Debug information: |
d3bc83c
to
74b28db
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/88eb81314e5a4a6981642cf854927fdd ✔️ openstack-meta-content-provider-master SUCCESS in 59m 47s Debug information: |
74b28db
to
ded806f
Compare
recheck |
In order to test opendev watcher master content in CI job, this pr adds following things: * opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from master content. It will help to test any opendev watcher patches with master edpm job. * It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance. * It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies. Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893 Depends-On: openstack-k8s-operators/ci-framework#2675 Related-Jira: https://issues.redhat.com/browse/OSPRH-11948 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
ded806f
to
d51e592
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/378ceb2cf55d4d379dc6e976711fdcbb ✔️ openstack-meta-content-provider-master SUCCESS in 2h 08m 37s |
In order to test opendev watcher master content in CI job, this pr adds following things:
opendev-master-watcher-operator-pipeline project template which will run meta content provider from master and then Deploy EDPM job watcher-operator-validation-master from mastter content. It will help to test any opendev watcher patches with master edpm job.
It changes the existing job watcher-operator-validation (still deploying the antelope content) with update_containers: false to avoid using meta content provider containers. This change will help to test master content with antelope job as
in downstream, we are going to backport lots of watcher master patches downstream. It will help to avoid breakage in advance.
It also updates the existing watcher-operator-validation and watcher-operator-kuttl job to use openstack-meta-content-provider-master as a job dependencies.
Depends-On: https://review.opendev.org/c/openstack/watcher/+/938893
Depends-On: openstack-k8s-operators/ci-framework#2675
Related-Jira: https://issues.redhat.com/browse/OSPRH-11948