-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run test pods with readOnlyRootFileSystem: true #256
Run test pods with readOnlyRootFileSystem: true #256
Conversation
Skipping CI for Draft Pull Request. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b80284a9580e4e9da36a39b26e15515e ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 38m 32s |
cb6b5b1
to
4edf588
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cf6b24dd75da42609e6384cda6085b97 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 26m 48s |
/test all |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/785b677ae6284477827d3665f605b0f9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 42s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/456573d5794742f593cac02cb634c405 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 02s |
4edf588
to
f9a66cc
Compare
Up until now the test pods were being spawned with writable root file system (readOnlyRootFilesystem: false). This is against the best security practices as setting the readOnlyRootFileSystem to false increases the size of the attack surface. This patch ensures that each pod spawned by the test-operator has the readOnlyRootFilesystem set to true by default. It is possible to run a pod with writable roo file system by setting privileged: true. Depends-On: openstack-k8s-operators/tcib#233
f9a66cc
to
046eae0
Compare
/test test-operator-build-deploy |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/751a5477abbb4697aac1ef6ed4d16970 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 20m 59s |
The promotion for the podified-antelope-centos9 did not pass yesterday (tcib image does not contain the fix yet): -> We have to wait. |
/test test-operator-build-deploy |
recheck promotion finally passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks Lukas
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kopecmartin, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7797cdf
into
openstack-k8s-operators:main
Up until now the test pods were being spawned with writable root
file system (
readOnlyRootFilesystem: false
). This is against thebest security practices as setting the
readOnlyRootFileSystem
tofalse
increases the size of the attack surface.This patch ensures that each pod spawned by the test-operator has
the
readOnlyRootFilesystem
set totrue
by default. It is possibleto run a pod with writable roo file system by setting
privileged: true
.Depends-On: openstack-k8s-operators/tcib#233