Enable watcher-dashboard panels if ENABLE_WATCHER is yes #242

amoralej · 2025-01-24T13:08:03Z

Following the same pattern that other plugins, this patch enable the pannels provided in the wathcher-dashboard if environmental value is set to yes.

To make it backwards compatible it is setting it as no by default and checks if the dashboard is installed before trying to enable it.

Related: OSPRH-11277

raukadah · 2025-01-24T13:35:25Z

/approve

amoralej · 2025-01-24T14:52:28Z

/test precommit-check

amoralej · 2025-01-24T15:19:29Z

/test images

softwarefactory-project-zuul · 2025-01-24T17:06:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/008169655f424b4eaa0ff3e5be121493

✔️ openstack-meta-content-provider SUCCESS in 3h 57m 56s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 2h 57m 41s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 2h 26m 13s

raukadah · 2025-01-27T05:23:51Z

https://logserver.rdoproject.org/42/242/90cd66b9cfed9d9ed382ffbcc19d443981c8ff30/github-check/tcib-podified-multinode-edpm-deployment-crc/243f72b/controller/ci-framework-data/tests/test_operator/tempest-tests-tempest/stestr_results.html test network basic ops failure. Not related this pr.

}}}

Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/tempest/common/utils/__init__.py", line 65, in wrapper
    return f(*func_args, **func_kwargs)
  File "/usr/lib/python3.9/site-packages/tempest/scenario/test_network_basic_ops.py", line 568, in test_update_router_admin_state
    self._check_public_network_connectivity(
  File "/usr/lib/python3.9/site-packages/tempest/scenario/test_network_basic_ops.py", line 211, in _check_public_network_connectivity
    self.check_vm_connectivity(
  File "/usr/lib/python3.9/site-packages/tempest/scenario/manager.py", line 1082, in check_vm_connectivity
    self.assertTrue(self.ping_ip_address(ip_address,
  File "/usr/lib64/python3.9/unittest/case.py", line 688, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true : Public network connectivity check failed. Reason: after updating admin_state_up of router to True
Timed out waiting for 192.168.122.199 to become reachable

raukadah · 2025-01-27T05:23:56Z

recheck

softwarefactory-project-zuul · 2025-01-27T09:28:09Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1cf82b8c2546494499b167ba7dfb6b56

✔️ openstack-meta-content-provider SUCCESS in 4h 02m 54s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 3h 06m 56s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 2h 15m 23s

raukadah · 2025-01-28T07:26:54Z

recheck same tempest failure vanished after recheck

softwarefactory-project-zuul · 2025-01-28T11:23:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2c7f88efd7a54aedbb4ea435eb77346f

✔️ openstack-meta-content-provider SUCCESS in 3h 55m 33s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 3h 02m 42s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 2h 32m 06s

amoralej · 2025-01-29T07:21:19Z

recheck

softwarefactory-project-zuul · 2025-01-29T10:36:21Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2ac066c8b38f4cc7b423d8c4a89e8d3f

✔️ openstack-meta-content-provider SUCCESS in 3h 13m 57s
❌ tcib-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 26s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 56m 48s

amoralej · 2025-01-29T14:04:22Z

recheck

softwarefactory-project-zuul · 2025-01-29T18:40:21Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5e8e127c76b4384b8be20cacd2f32c2

✔️ openstack-meta-content-provider SUCCESS in 4h 08m 25s
✔️ tcib-crc-podified-edpm-baremetal SUCCESS in 2h 14m 59s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 24m 27s

amoralej · 2025-01-30T07:30:43Z

recheck
seems flaky tests

softwarefactory-project-zuul · 2025-01-30T10:34:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6efc32a7e4d34913b5bce0d350b10918

✔️ openstack-meta-content-provider SUCCESS in 3h 02m 24s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 2h 01m 20s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 23m 11s

eduolivares · 2025-01-30T13:34:05Z

recheck
Depends-On added to the PR description should fix the tobiko failures.

softwarefactory-project-zuul · 2025-01-30T14:44:42Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ba8643650774455b910f1dfc5541fd1d

❌ openstack-meta-content-provider FAILURE in 50m 10s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-meta-content-provider

amoralej · 2025-01-30T15:07:19Z

recheck

softwarefactory-project-zuul · 2025-01-30T19:34:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/33bab90cb40e45bf9270b219ebe01a0c

✔️ openstack-meta-content-provider SUCCESS in 3h 14m 05s
❌ tcib-crc-podified-edpm-baremetal FAILURE in 2h 06m 01s
❌ tcib-podified-multinode-edpm-deployment-crc FAILURE in 1h 30m 37s

eduolivares · 2025-01-30T20:12:32Z

I have reviewed the tobiko logs and there is something wrong. It looks like a bug in test-operator. I will investigate tomorrow.

At [1] environment is empty (wrong).
At [2] environment is correct.

And there are some other issues. I think we should disable tobiko tests to avoid blocking tcib, for the moment.

[1] https://logserver.rdoproject.org/42/242/90cd66b9cfed9d9ed382ffbcc19d443981c8ff30/github-check/tcib-crc-podified-edpm-baremetal/dd53ad9/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tobiko-tests-tobiko-workflow-step-00-sanity-ftb7n/tobiko-tests-tobiko-workflow-step-00-sanity-ftb7n-describe

[2] https://logserver.rdoproject.org/42/242/90cd66b9cfed9d9ed382ffbcc19d443981c8ff30/github-check/tcib-crc-podified-edpm-baremetal/dd53ad9/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/tobiko-tests-tobiko-workflow-step-01-scenario-nova-dw5pv/tobiko-tests-tobiko-workflow-step-01-scenario-nova-dw5pv-describe

rabi · 2025-01-31T05:59:23Z

I've propsed to remove them #245. Let's discuss before we introduce these again as I'm not sure if we should run them here.

Following the same pattern that other plugins, this patch enable the pannels provided in the wathcher-dashboard if environmental value is set to `yes`. To make it backwards compatible it is setting it as no by default and checks if the dashboard is installed before trying to enable it.

rabi

/lgtm

openshift-ci · 2025-02-04T06:41:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej, deshipu, rabi, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rabi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from bshephar and lewisdenny January 24, 2025 13:08

deshipu approved these changes Jan 24, 2025

View reviewed changes

openshift-ci bot assigned deshipu Jan 24, 2025

openshift-ci bot added the lgtm label Jan 24, 2025

rlandy added the approved label Jan 27, 2025

amoralej force-pushed the watcher branch from 90cd66b to bd2fa10 Compare January 31, 2025 09:04

openshift-ci bot removed the lgtm label Jan 31, 2025

rabi approved these changes Feb 4, 2025

View reviewed changes

openshift-ci bot assigned rabi Feb 4, 2025

openshift-ci bot added the lgtm label Feb 4, 2025

openshift-merge-bot bot merged commit 01ff037 into openstack-k8s-operators:main Feb 4, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable watcher-dashboard panels if ENABLE_WATCHER is yes #242

Enable watcher-dashboard panels if ENABLE_WATCHER is yes #242

amoralej commented Jan 24, 2025 •

edited by eduolivares

Loading

raukadah commented Jan 24, 2025

amoralej commented Jan 24, 2025

amoralej commented Jan 24, 2025

softwarefactory-project-zuul bot commented Jan 24, 2025

raukadah commented Jan 27, 2025

raukadah commented Jan 27, 2025

softwarefactory-project-zuul bot commented Jan 27, 2025

raukadah commented Jan 28, 2025

softwarefactory-project-zuul bot commented Jan 28, 2025

amoralej commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

amoralej commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

amoralej commented Jan 30, 2025

softwarefactory-project-zuul bot commented Jan 30, 2025

eduolivares commented Jan 30, 2025

softwarefactory-project-zuul bot commented Jan 30, 2025

amoralej commented Jan 30, 2025

softwarefactory-project-zuul bot commented Jan 30, 2025

eduolivares commented Jan 30, 2025 •

edited

Loading

rabi commented Jan 31, 2025

rabi left a comment

openshift-ci bot commented Feb 4, 2025

Enable watcher-dashboard panels if ENABLE_WATCHER is yes #242

Enable watcher-dashboard panels if ENABLE_WATCHER is yes #242

Conversation

amoralej commented Jan 24, 2025 • edited by eduolivares Loading

raukadah commented Jan 24, 2025

amoralej commented Jan 24, 2025

amoralej commented Jan 24, 2025

softwarefactory-project-zuul bot commented Jan 24, 2025

raukadah commented Jan 27, 2025

raukadah commented Jan 27, 2025

softwarefactory-project-zuul bot commented Jan 27, 2025

raukadah commented Jan 28, 2025

softwarefactory-project-zuul bot commented Jan 28, 2025

amoralej commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

amoralej commented Jan 29, 2025

softwarefactory-project-zuul bot commented Jan 29, 2025

amoralej commented Jan 30, 2025

softwarefactory-project-zuul bot commented Jan 30, 2025

eduolivares commented Jan 30, 2025

softwarefactory-project-zuul bot commented Jan 30, 2025

amoralej commented Jan 30, 2025

softwarefactory-project-zuul bot commented Jan 30, 2025

eduolivares commented Jan 30, 2025 • edited Loading

rabi commented Jan 31, 2025

rabi left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Feb 4, 2025

amoralej commented Jan 24, 2025 •

edited by eduolivares

Loading

eduolivares commented Jan 30, 2025 •

edited

Loading