Build openstack-watcher container #215

raukadah · 2024-09-26T09:44:33Z

This pull request:
* Builds OpenStack Watcher containers
* Add python-watcherclient package to openstackclient container
* Add openstack-watcher-ui package to horizon container

Note: python-watcherclient and openstack-watcher-ui is not available in downstream currently. It is available in CentOS Stream with RDO antelope release. That's why we have added these packages under tcib_distro conditional to avoid breakage downstream.

Test results: #215 (comment)

Jira: https://issues.redhat.com/browse/OSPRH-11085
Co-authored-by: Alfredo Moralejo amoralej@redhat.com
Signed-off-by: Chandan Kumar raukadah@gmail.com

softwarefactory-project-zuul · 2024-09-26T11:25:04Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/009b2d2b9cb144478d5d71af89970d0b

❌ openstack-meta-content-provider FAILURE in 23m 49s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-meta-content-provider

raukadah · 2024-09-26T14:49:15Z

/assign @rlandy

amoralej · 2024-10-11T09:25:55Z

container-images/tcib/base/os/watcher-base/watcher-base.yaml

+  - httpd
+  - mod_ssl
+  - openstack-watcher-common
+  - python3-mod_wsgi


Only the watcher-api runs as a wsgi in httpd, I'd move httpd, mod_ssl and python3-mod_wsgi to the watcher-api container.

Thank you for the updating in the pr!

softwarefactory-project-zuul · 2024-10-14T15:07:11Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/430f4b85b356447da30bead4066d555e

❌ openstack-meta-content-provider FAILURE in 15m 46s
⚠️ tcib-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ tcib-podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-meta-content-provider

raukadah · 2024-11-04T09:03:18Z

recheck

Watcher related packages got added in RDO antelope but not available in OSP-18 downstream. openstack-k8s-operators/tcib#215 adds watcher container in tcib. Since downstream tcib jobs install the tcib rpm from main branch so it may break downstream container build and component job. So in order to avoid breakage, we are skip building watcher related containers. Signed-off-by: Chandan Kumar <raukadah@gmail.com>

Watcher related packages got added in RDO antelope but not available in OSP-18 downstream. openstack-k8s-operators/tcib#215 adds watcher container in tcib. Since downstream tcib jobs install the tcib rpm from main branch so it may break downstream container build and component job. So in order to avoid breakage, we are skip building watcher related containers. Depends-On: openstack-k8s-operators/tcib#215 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

Watcher related packages got added in RDO antelope but not available in OSP-18 downstream. openstack-k8s-operators/tcib#215 adds watcher container in tcib. Since downstream tcib jobs install the tcib rpm from main branch so it may break downstream container build and component job. So in order to avoid breakage, we are skip building watcher related containers. Note: It also fixes the exclude conditional to check existence of release key in exclude var to avoid following error: ``` ''dict object'' has no attribute ''master''' ``` Depends-On: openstack-k8s-operators/tcib#215 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

raukadah · 2024-11-06T11:35:10Z

From openstack meta content provider results, Link to watcher containers: https://logserver.rdoproject.org/15/215/84602e0ec8da34c3c73dca78c2b8f0d5df5ae6ea/github-check/openstack-meta-content-provider/6664be7/ci-framework-data/logs/4c45eaca-5ae8-415a-b049-47c753375d81/base/os/watcher-base/

amoralej · 2024-11-06T15:51:52Z

container-images/kolla/horizon/extend_start.sh

+        "${SITE_PACKAGES}/watcher_dashboard/conf/watcher_policy.json" \
+        "/etc/openstack-dashboard/watcher_policy.json"
+}
+


I'm afraid of breaking horizon deployment downstream by adding this as we need ENABLE_WATCHER as this script requires ENABLE_WATCHER variable which we need to add in horizon-operator and also requires files which are installed by openstack-watcher-ui which will not be installed downstream. What if we add the dashboard configuration part for a future PR or at least don't run it so far?

@amoralej Yes, indeed, it will break. I am moving this whole piece. https://issues.redhat.com/browse/OSPRH-11277 will track the same, will add it in future pr.

amoralej · 2024-11-06T15:52:04Z

container-images/kolla/horizon/extend_start.sh

@@ -105,6 +117,7 @@ config_heat_dashboard
 config_ironic_dashboard
 config_manila_ui
 config_octavia_dashboard
+config_watcher_dashboard


This pull request: * Builds OpenStack Watcher containers * Add python-watcherclient package to openstackclient container * Add openstack-watcher-ui package to horizon container Note: python-watcherclient and openstack-watcher-ui is not available in downstream currently. It is available in CentOS Stream with RDO antelope release. That's why we have added these packages under tcib_distro conditional to avoid breakage downstream. Jira: https://issues.redhat.com/browse/OSPRH-11085 Co-authored-by: Alfredo Moralejo <amoralej@redhat.com> Signed-off-by: Chandan Kumar <raukadah@gmail.com>

amoralej

lgtm

rabi

Is watcher service going to be tech-preview in a OSP 18 Feature Release or OSP19? Is there any PM agreement for that you could link it the linked jira?

openshift-ci · 2024-11-07T03:18:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rabi, raukadah, rlandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rabi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

raukadah · 2024-11-07T09:08:14Z

Is watcher service going to be tech-preview in a OSP 18 Feature Release or OSP19? Is there any PM agreement for that you could link it the linked jira?

@rabi Hello, thank you for the comments, https://issues.redhat.com/browse/OSPRH-7674 tracks it and it is targeted as a tech preview in RHOS-18.0 FR 2 release.

raukadah · 2025-01-31T10:02:21Z

/cherry-pick 18.0-fr1

openshift-cherrypick-robot · 2025-01-31T10:02:59Z

@raukadah: new pull request created: #247

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from son-vyas and viroel September 26, 2024 09:44

openshift-ci bot added the approved label Sep 26, 2024

raukadah force-pushed the add_watcher branch from c75f19c to 872d312 Compare September 26, 2024 09:46

raukadah marked this pull request as draft September 26, 2024 09:46

openshift-ci bot added the do-not-merge/work-in-progress label Sep 26, 2024

raukadah force-pushed the add_watcher branch from 872d312 to bc7fa66 Compare September 26, 2024 14:48

openshift-ci bot assigned rlandy Sep 26, 2024

amoralej reviewed Oct 11, 2024

View reviewed changes

amoralej force-pushed the add_watcher branch from bc7fa66 to c08bab7 Compare October 14, 2024 14:17

openshift-ci bot removed the approved label Oct 14, 2024

raukadah force-pushed the add_watcher branch from c08bab7 to 84602e0 Compare November 4, 2024 15:30

raukadah mentioned this pull request Nov 4, 2024

Skip watcher containers for downstream openstack-k8s-operators/ci-framework#2515

Closed

raukadah marked this pull request as ready for review November 5, 2024 10:35

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 5, 2024

openshift-ci bot requested review from abays and stuggi November 5, 2024 10:35

rlandy approved these changes Nov 6, 2024

View reviewed changes

openshift-ci bot added the lgtm label Nov 6, 2024

amoralej reviewed Nov 6, 2024

View reviewed changes

raukadah force-pushed the add_watcher branch from 84602e0 to 00ae709 Compare November 6, 2024 16:25

openshift-ci bot removed the lgtm label Nov 6, 2024

amoralej reviewed Nov 6, 2024

View reviewed changes

rabi approved these changes Nov 7, 2024

View reviewed changes

openshift-ci bot assigned rabi Nov 7, 2024

openshift-ci bot added the lgtm label Nov 7, 2024

openshift-ci bot added the approved label Nov 7, 2024

openshift-merge-bot bot merged commit bcb58ab into openstack-k8s-operators:main Nov 7, 2024
5 checks passed

raukadah deleted the add_watcher branch November 7, 2024 09:11

openshift-cherrypick-robot mentioned this pull request Jan 31, 2025

[18.0-fr1] Build openstack-watcher container #247

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build openstack-watcher container #215

Build openstack-watcher container #215

raukadah commented Sep 26, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Sep 26, 2024

raukadah commented Sep 26, 2024

amoralej Oct 11, 2024

raukadah Nov 6, 2024

softwarefactory-project-zuul bot commented Oct 14, 2024

raukadah commented Nov 4, 2024

raukadah commented Nov 6, 2024

amoralej Nov 6, 2024

raukadah Nov 6, 2024

amoralej Nov 6, 2024

raukadah Nov 6, 2024

amoralej left a comment

rabi left a comment

openshift-ci bot commented Nov 7, 2024

raukadah commented Nov 7, 2024

raukadah commented Jan 31, 2025

openshift-cherrypick-robot commented Jan 31, 2025

Build openstack-watcher container #215

Build openstack-watcher container #215

Conversation

raukadah commented Sep 26, 2024 • edited Loading

softwarefactory-project-zuul bot commented Sep 26, 2024

raukadah commented Sep 26, 2024

amoralej Oct 11, 2024

Choose a reason for hiding this comment

raukadah Nov 6, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Oct 14, 2024

raukadah commented Nov 4, 2024

raukadah commented Nov 6, 2024

amoralej Nov 6, 2024

Choose a reason for hiding this comment

raukadah Nov 6, 2024

Choose a reason for hiding this comment

amoralej Nov 6, 2024

Choose a reason for hiding this comment

raukadah Nov 6, 2024

Choose a reason for hiding this comment

amoralej left a comment

Choose a reason for hiding this comment

rabi left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Nov 7, 2024

raukadah commented Nov 7, 2024

raukadah commented Jan 31, 2025

openshift-cherrypick-robot commented Jan 31, 2025

raukadah commented Sep 26, 2024 •

edited

Loading