Add dump-conf option to the mask secret script #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the ability to the mask script to detect a .conf file (as key in a secret), and dump its content in the current directory. This helps to ease the troubleshooting when looking for a service config file: instead of base64 -d a portion of the secret, we provide a dump of that file in the form <secret.yaml>-<config_file_name>.conf within the same directory. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount
requested review from
rebtoor,
lewisdenny,
abays,
stuggi and
pablintino
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 265e668
into
openstack-k8s-operators:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to detect a
.conffile within aSecretand dump its content in the current directory.This helps to ease the troubleshooting when looking for a service config file: instead of
base64 -da portion of theSecret, we provide a dump of that file in the form<secret.yaml>-<config_file_name>.confwithin the same directory.For CI only purposes, there are situations where is required to look at connection strings, username and passwords generated in the operators context. For this reason a
DO_NOT_MASKenvironment variable is provided to entirely bypass (in CI) the masking mechanism.Implements: OSPRH-726