Update disable_reason when evacuation fails and other fixes #339
+89
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit brings the following changes: 1. When evacuations fail we want to update the disable_log_reason field so users can immediately see the reason, plus we can filter out these computes and not try to evacuate them again. 2. We now filter out evacuations that are 'failed' when deciding if a compute can be re-enabled after it has been fenced, as it is preferable to avoid users the additional burden of manually re-enabling the hypervisors if not necessary. If necessary the LEAVE_DISABLED option can be used to keep a host down. 3. We wrap the initial call to nova api in try/except to give users evidence in the logs if nova is not available. 4. We added a FORCE_ENABLE parameter. If true, ignore any failed evacuation and enable computes after evacuation. Jira: https://issues.redhat.com/browse/OSPRH-11279
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lmiccini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test functional |
1 similar comment
|
/test functional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings the following changes:
When evacuations fail we want to update the disable_log_reason field so users can immediately see the reason, plus we can filter out these computes and not try to evacuate them again.
We now filter out evacuations that are 'failed' when deciding if a compute can be re-enabled after it has been fenced, as it is preferable to avoid users the additional burden of manually re-enabling the hypervisors if not necessary.
If necessary the LEAVE_DISABLED option can be used to keep a host down.
We wrap the initial call to nova api in try/except to give users evidence in the logs if nova is not available.
We added a FORCE_ENABLE parameter. If true, ignore any failed evacuation and enable computes after evacuation.
Jira: https://issues.redhat.com/browse/OSPRH-11279