Drop Debug fields #327
Drop Debug fields #327
Conversation
|
Thanks for the PR, I'm putting it on hold until I can confirm that I can do everything I need for customer engagements with the |
let me know if something is not possible |
Since then we merged this drop in all the other service operators. Could you be a bit more specific what issue do you foresee? |
|
/test cinder-operator-build-deploy-kuttl |
|
/test cinder-operator-build-deploy-tempest |
|
/retest |
There was a problem hiding this comment.
The downvote is because there is a duplicated line in the code that should be removed. The PR looks good to me otherwise.
I have looked into the replacement of the debug section with the oc debug command and all the primary cases seem to be covered.
I have proposed a small improvement on the documentation to explicitly show how we can do some of the debugging scenarios: openstack-k8s-operators/dev-docs#96
One scenario that would not be covered is debugging the db sync job pod when it doesn't fail. If it fails we can debug it, but if the job completes and disappears then we cannot debug it. I don't think it's a big problem, since the common case would be to debug it on failure.
pkg/cinderapi/statefuleset.go
Outdated
| @@ -113,6 +101,7 @@ func StatefulSet( | |||
| volumeMounts = append(volumeMounts, svc.CreateVolumeMounts(endpt.String())...) | |||
| } | |||
| } | |||
| readinessProbe.HTTPGet = livenessProbe.HTTPGet | |||
There was a problem hiding this comment.
-1: This line is unnecessary, we already set it on L66
These fields were redundant. Crashing pods can be debugged via oc debug. Implements: OSPRH-4290
|
/test cinder-operator-build-deploy-kuttl |
|
/test cinder-operator-build-deploy-tempest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, gibizer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit 376faf4
into
openstack-k8s-operators:main
…shares Fix Manila template when ManilaShares is empty
These fields were redundant. Crashing pods can be debugged via oc debug.
Implements: OSPRH-4290