Add Ansible variable cifmw_openshift_setup_apply_marketplace_fix #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpawlik
requested review from
pablintino,
lewisdenny,
evallesp,
bshewale and
frenzyfriday
as code owners
danpawlik
force-pushed
the
parametrize-marketplace-fix
branch
4 times, most recently
from
9274111 to
8edf478
Compare
danpawlik
changed the title
|
I'd say, let's accept this change, create and create a task to delete everything if nothing breaks. |
On some images (especially on legacy CRC images e.g. 2.30.0), there is no need to run the openshift-marketplace workaround which is removing all the pods from the namespace. That step might be problematic on old deployments, due the ImagePullPolicy is set to "Always", so after removing the pods when the credentials are vanished, pods would be not recreated. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
parametrize-marketplace-fix
branch
from
8edf478 to
b7b4f6f
Compare
frenzyfriday
approved these changes
Feb 10, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshewale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@frenzyfriday I think it can be disabled now, no need to re-run similar command as it is done already in base job. |
bshewale
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some images (especially on legacy CRC images e.g. 2.30.0), there is no need to run the openshift-marketplace workaround which is removing all the pods from the namespace.
That step might be problematic on old deployments, due the ImagePullPolicy is set to "Always", so after removing the pods when the credentials are vanished, pods would be not recreated.