Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DS tigger PoC content #2703

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Remove DS tigger PoC content #2703

merged 1 commit into from
Feb 5, 2025

Conversation

pablintino
Copy link
Collaborator

No description provided.

frenzyfriday
frenzyfriday previously approved these changes Feb 4, 2025
Copy link
Collaborator

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenzyfriday frenzyfriday enabled auto-merge (rebase) February 4, 2025 14:28
@bshewale
Copy link
Contributor

bshewale commented Feb 4, 2025

LGTM

@bshewale
Copy link
Contributor

bshewale commented Feb 4, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshewale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
evallesp
evallesp previously approved these changes Feb 4, 2025
Copy link

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pablintino
Copy link
Collaborator Author

recheck

@pablintino pablintino dismissed stale reviews from evallesp and frenzyfriday via b95debc February 4, 2025 17:09
@pablintino pablintino force-pushed the remove-ds-trigger-poc branch from f1995e8 to b95debc Compare February 4, 2025 17:09
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pablintino

@frenzyfriday frenzyfriday merged commit c0cf6f2 into main Feb 5, 2025
5 checks passed
@frenzyfriday frenzyfriday deleted the remove-ds-trigger-poc branch February 5, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants