[openshift_setup] Add support for overriding dependent operators CatalogSource #2694
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ecec170bd3104576a89ea2a78c57819c ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 33s |
lewisdenny
force-pushed
the
4.17_operators
branch
from
d4b8f9e to
c30c162
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eb7e705be4114ebda9f0a21729642e38 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 56s |
lewisdenny
force-pushed
the
4.17_operators
branch
from
c30c162 to
203c5ef
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d66b44e84dfc459d973537c0f6d299b0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 09m 34s |
lewisdenny
force-pushed
the
4.17_operators
branch
2 times, most recently
from
52409d6 to
c281822
Compare
roles/openshift_setup/tasks/patch_dependent_operators_source.yml
Outdated
Show resolved
Hide resolved
lewisdenny
requested review from
pablintino,
evallesp,
bshewale and
frenzyfriday
as code owners
lewisdenny
changed the title
…logSource This is needed to easily test pre-release versions of OCP. OpenStack depends on a few operators, these operators don't easily expose pre-release versions for installation. A hack like this patch allows a user to create a new CatalogSource for the current GA version of OCP and patch the dependent operators to install from it.
lewisdenny
force-pushed
the
4.17_operators
branch
from
c281822 to
ec2eb3d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
| - name: Create catalog source and switch dependent operators to consume it | ||
| when: | ||
| - cifmw_openshift_setup_enable_operator_catalog_override | | ||
| default(false) | bool | ||
| ansible.builtin.import_role: | ||
| name: openshift_setup | ||
| tasks_from: patch_dependent_operators_source.yml | ||
|
|
There was a problem hiding this comment.
Do we really need this call here?
If we follow what's done in that role what I'd expect is just another include_tasks at the end with cifmw_openshift_setup_enable_operator_catalog_override as a conditional and the proper default in the role defaults file.
The role runs always and before this one so we should be safe.
There was a problem hiding this comment.
I can't validate currently because downstream CI infra is having an outage but my understanding is when the openshift_setup role runs, the subscriptions do not yet exist.
Yes I could create the CatalogSource when openshift_setup runs but I wanted to keep the logic together.
I could also create the subscriptions rather than patching them and maybe OLM wouldn't complain but this is already a nasty hack that I'm trying to minimise the footprint.
I can verify once downstream CI infra is back.
This is needed to easily test pre-release versions of OCP. OpenStack
depends on a few operators, these operators don't easily expose
pre-release versions for installation. A hack like this patch allows a
user to create a new CatalogSource for the current GA version of OCP and
patch the dependent operators to install from it.
JIRA: https://issues.redhat.com/browse/OSPRH-13706