Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance test_operator role for flexible test workflows #2689

Draft
wants to merge 1 commit into
base: 18.0-fr1
Choose a base branch
from
Draft

Enhance test_operator role for flexible test workflows #2689

wants to merge 1 commit into from
+246 −149

Conversation

eshulman2
Copy link
Contributor

@eshulman2 eshulman2 commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

This commit adds key improvements to the test_operator role:

Support for defining test execution order.
Ability to run the same testing controller multiple times. Pre-hooks and post-hooks for stage-specific customization. Per-stage variable overrides via files or test_vars. Refactored pre-set testing stages to enable more dynamic test management and extend hook behavior for complex scenarios.

Jira: OSPRH-10106

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0-fr1. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@18.0-fr1", line 150

@github-actions github-actions bot marked this pull request as draft January 29, 2025 10:35
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0-fr1. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@18.0-fr1", line 150

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0-fr1. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@18.0-fr1", line 150

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Zuul encountered a syntax error while parsing its
configuration in the repo openstack-k8s-operators/ci-framework on branch 18.0-fr1. The
problem was:

Nodeset centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells does not match existing definition in branch main

The problem appears in the the "centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells" nodeset stanza:

nodeset:
name: centos-9-multinode-rhel-9-2-crc-extracted-2-39-0-3xl-novacells
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-39-0-3xl
- name: undercloud
label: cloud-rhel-9-2-tripleo
...

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@18.0-fr1", line 150

@eshulman2 @pablintino
Enhance test_operator role for flexible test workflows
97f5d70 
This commit adds key improvements to the test_operator role:

Support for defining test execution order.
Ability to run the same testing controller multiple times.
Pre-hooks and post-hooks for stage-specific customization.
Per-stage variable overrides via files or test_vars.
Refactored pre-set testing stages to enable more dynamic test
management and extend hook behavior for complex scenarios.

Jira: OSPRH-10106
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Collaborator

@eshulman2 I think I've fixed the branch history to remove the zuul error. Are you still interested in getting this one in for the fr1 branch?

@eshulman2
Copy link
Contributor Author

@eshulman2 I think I've fixed the branch history to remove the zuul error. Are you still interested in getting this one in for the fr1 branch?

yes, we need it D/S before the upcoming release

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ccecebf3a3884680a065465970dafac8

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 02m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 39s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 40s
❌ podified-multinode-hci-deployment-crc FAILURE in 2h 45m 30s
✔️ cifmw-multinode-tempest SUCCESS in 1h 53m 49s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 28s
❌ cifmw-pod-zuul-files FAILURE in 4m 08s
✔️ build-push-container-cifmw-client SUCCESS in 19m 07s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 32s

@pablintino
Copy link
Collaborator

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/941fe82ad1ae4de2830525d4e23ba933

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 27m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 49s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 18s
❌ podified-multinode-hci-deployment-crc FAILURE in 2h 42m 46s
❌ cifmw-multinode-tempest FAILURE in 1h 39m 32s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 24s
❌ cifmw-pod-zuul-files FAILURE in 4m 16s
✔️ build-push-container-cifmw-client SUCCESS in 18m 40s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 19s

@pablintino
Copy link
Collaborator

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8d72783ce71f4fb4bdbc14678d0dde13

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 12s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 7m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 49s
❌ podified-multinode-hci-deployment-crc RETRY_LIMIT in 12m 34s
❌ cifmw-multinode-tempest RETRY_LIMIT in 7m 17s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 34s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 29s
❌ cifmw-pod-zuul-files FAILURE in 4m 12s
✔️ build-push-container-cifmw-client SUCCESS in 18m 52s
✔️ cifmw-molecule-test_operator SUCCESS in 5m 14s

@pablintino
Copy link
Collaborator

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/966de1afcf934339a65f3438f84b2588

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 00m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 29m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 47s
❌ podified-multinode-hci-deployment-crc FAILURE in 2h 45m 33s
❌ cifmw-multinode-tempest FAILURE in 1h 34m 25s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 33s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 18s
❌ cifmw-pod-zuul-files FAILURE in 4m 11s
✔️ build-push-container-cifmw-client SUCCESS in 18m 25s
✔️ cifmw-molecule-test_operator SUCCESS in 5m 46s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlobillo rlobillo Awaiting requested review from rlobillo rlobillo will be requested when the pull request is marked ready for review rlobillo is a code owner

@eurijon eurijon Awaiting requested review from eurijon eurijon will be requested when the pull request is marked ready for review eurijon is a code owner

@pablintino pablintino Awaiting requested review from pablintino pablintino will be requested when the pull request is marked ready for review pablintino is a code owner

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny will be requested when the pull request is marked ready for review lewisdenny is a code owner

@evallesp evallesp Awaiting requested review from evallesp evallesp will be requested when the pull request is marked ready for review evallesp is a code owner

@bshewale bshewale Awaiting requested review from bshewale bshewale will be requested when the pull request is marked ready for review bshewale is a code owner

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday frenzyfriday will be requested when the pull request is marked ready for review frenzyfriday is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshulman2 @pablintino