Fix adoption_vars, only one defaultRoute #2653
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
hjensas
changed the title
hjensas
force-pushed
the
OSPRH-13013
branch
2 times, most recently
from
7ccaa46 to
c03c060
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fbcb266f99b9418aadbc35770666c582 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 53s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/32c98bfd5b8d4d09863b445b3c7ea17d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 41s |
hjensas
force-pushed
the
OSPRH-13013
branch
4 times, most recently
from
9831c8c to
2ffa70a
Compare
With PR# 2548 support was added for multiple edpm nodesets, these may not have the same networks attached - i.e Compute and Networkere nodes have different network needs. When introducing this support the `networks` was made dynamic, and the `defaultRoute` was set for every network. Only one network can have the `defaultRoute`, this caused an error when deploying the openstackdataplanenodeset. Restore the behaviour prior to PR# 2548 - which would only set `defaultRoute` for the `ctlplane` network. Also, filter the cifmw_libvirt_manager_pub_net when generating networks for edpm_nodes. cifmw_libvirt_manager_pub_net (typically named ocpbm) is a ci-framework "management" network and should not be included in the EDPM nodeset configs. Jira: OSPRH-1301
With PR#2548 support was added for multiple edpm nodesets, these may not have the same networks attached - i.e Compute and Networkere nodes have different network needs. When introducing this support the
networkswas made dynamic, and thedefaultRoutewas set for every network.Only one network can have the
defaultRoute, this caused an error when deploying the openstackdataplanenodeset.Restore the behaviour prior to #2548 - which would only set
defaultRoutefor thectlplanenetwork.Also, filter the cifmw_libvirt_manager_pub_net when generating networks
for edpm_nodes. cifmw_libvirt_manager_pub_net (typically named ocpbm) is
a ci-framework "management" network and should not be included in the
EDPM nodeset configs.
Jira: OSPRH-13013