Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre adoption resources delete hook #2648

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add pre adoption resources delete hook #2648

merged 1 commit into from
Jan 30, 2025
+53 −0

Conversation

eshulman2
Copy link
Contributor

NFV adoption job requires an addtional hook for resource delete when running adoption with pre-created performance resources added a hook to delete the required resources

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft January 15, 2025 10:08
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from cb4f473 to 055bdea Compare January 15, 2025 10:10
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7199c254d2e348b584d01f5be97640d3

❌ openstack-k8s-operators-content-provider FAILURE in 12m 17s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 34s
❌ cifmw-pod-pre-commit FAILURE in 7m 53s
✔️ build-push-container-cifmw-client SUCCESS in 37m 21s

@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from 055bdea to c98931e Compare January 16, 2025 15:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 2648,c98931e4fab9484e2291a2cdf15d3da51ad771c6

@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from c98931e to d371fda Compare January 16, 2025 15:43
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 2648,d371fda3cf1ce784a49a07e00efe6ca15a61c06a

@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from d371fda to 715cae8 Compare January 16, 2025 15:47
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 2648,715cae8a8181fcb59cfc6f1782f94e546f7b703d

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a126fba56e34980a2698622fa292e28

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 53s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 37s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 10s
❌ cifmw-pod-pre-commit FAILURE in 7m 27s
✔️ build-push-container-cifmw-client SUCCESS in 36m 44s

@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from afb6d4a to 8f02183 Compare January 22, 2025 10:00
@eshulman2 eshulman2 marked this pull request as ready for review January 22, 2025 10:01
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/88e9f967153846c8aa49e12ce67a2948

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 30s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 14s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 28s
❌ cifmw-pod-pre-commit FAILURE in 8m 04s
✔️ build-push-container-cifmw-client SUCCESS in 22m 32s

@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from 8f02183 to 1c58fe1 Compare January 22, 2025 11:45
@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from 1c58fe1 to 2f7042e Compare January 27, 2025 13:17
@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from 2f7042e to 90a5ce6 Compare January 27, 2025 13:18
@eshulman2 eshulman2 requested a review from dsariel January 27, 2025 14:16
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/349b3940a39d44038f787a6e64fec3e0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 35s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 26m 20s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 24m 02s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 54s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 32s
✔️ build-push-container-cifmw-client SUCCESS in 17m 08s

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a5316c3827d44c5584dbe9116a9d5e93

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 35s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 16m 01s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 29m 15s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 06s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 28s
✔️ build-push-container-cifmw-client SUCCESS in 22m 01s

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/370b5af63ea8497c8aba41b2833f278e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 38s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 24m 27s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 41m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 26s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 17s
✔️ build-push-container-cifmw-client SUCCESS in 17m 11s

@eshulman2
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4565b783f0cc4d418b92d1a742803165

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 31s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 23m 00s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 55m 58s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 38s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 41s
✔️ build-push-container-cifmw-client SUCCESS in 17m 10s

@eshulman2
Add pre adoption resources delete hook
92f979e 
NFV adoption job requires an addtional hook for resource delete when
running adoption with pre-created performance resources added a hook to
delete the required resources
@eshulman2 eshulman2 force-pushed the delete_resources_hook branch from 90a5ce6 to 92f979e Compare January 29, 2025 11:11
@frenzyfriday frenzyfriday merged commit 6295c4e into openstack-k8s-operators:main Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsariel dsariel dsariel approved these changes

@frenzyfriday frenzyfriday frenzyfriday approved these changes

@pablintino pablintino Awaiting requested review from pablintino pablintino is a code owner

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny is a code owner

@evallesp evallesp Awaiting requested review from evallesp evallesp is a code owner

@bshewale bshewale Awaiting requested review from bshewale bshewale is a code owner

Assignees
No one assigned
Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eshulman2 @dsariel @frenzyfriday @openshift-merge-robot