Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypervisor param to shiftstack playbook execution #2626

Merged

Conversation

eurijon
Copy link
Contributor

@eurijon eurijon commented Dec 27, 2024

For being able to resolve shift-on-stack apps endpoints (routes) hostnames from RHOSO pods it's required to add the DNS record entry in then dnsmasq service running on the hypervisor.

i.e.:

# cat /etc/cifmw-dnsmasq.d/addresses.conf 
address=/apps.ocp.openstack.lab/x.y.z.v
address=/apps.ostest.shiftstack.local/x.y.z.s      <<-----

It needs to be done after shift-on-stack cluster is installed as the installer is creating the floating IP for the apps endpoints, and the FIP is not known in advance.

For that purpose the cifmw_shiftstack_hypervisor param is passed so the playbook running on the shiftstackclient pod is able to reach the hypervisor.

The PR also adds the cifmw_shiftstack_shiftstackclient_incluster_kubeconfig_dir param to the shiftstack-qa playbook execution so it's able to find the RHOSO kubeconfig location.

This PR depends on: #2620

Copy link
Contributor

openshift-ci bot commented Dec 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 2626,63abc8fc4ea820ac8a7f84508f6ef9c8190997a3

Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ci-framework for 2626,b875b3409fa8dcb132a445dcb0abf40b2bffb4d6

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d146909601c5464095bc146e4964e874

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 24s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 07s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 02s
✔️ build-push-container-cifmw-client SUCCESS in 20m 45s
cifmw-molecule-shiftstack FAILURE in 14m 46s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a964b20bcbb41d8a19fcd79f024b377

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 48s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 42s
cifmw-pod-pre-commit FAILURE in 7m 42s
✔️ build-push-container-cifmw-client SUCCESS in 35m 59s
cifmw-molecule-shiftstack FAILURE in 15m 39s

@eurijon eurijon force-pushed the hypervisor-param branch 5 times, most recently from 1bf8556 to cdcd1c3 Compare December 30, 2024 16:29
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5114043cc42740c3bb98c72e8d96353c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 59s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 53s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 40m 46s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 32s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 05s
✔️ build-push-container-cifmw-client SUCCESS in 36m 54s
✔️ cifmw-molecule-shiftstack SUCCESS in 12m 41s

@eurijon
Copy link
Contributor Author

eurijon commented Dec 31, 2024

recheck

@eurijon eurijon marked this pull request as ready for review December 31, 2024 10:17
@eurijon eurijon requested a review from rlobillo as a code owner December 31, 2024 10:17
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5b12142c52de4956bbbd006dd986e8b4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 13s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 26m 18s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 17s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 18s
✔️ build-push-container-cifmw-client SUCCESS in 36m 02s
✔️ cifmw-molecule-shiftstack SUCCESS in 12m 55s

@eurijon
Copy link
Contributor Author

eurijon commented Dec 31, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ea028ac29fff478697304da0accad1f3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 20s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 37m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 53s
✔️ build-push-container-cifmw-client SUCCESS in 36m 46s
✔️ cifmw-molecule-shiftstack SUCCESS in 13m 47s

@eurijon
Copy link
Contributor Author

eurijon commented Jan 9, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1959cb648eac4a9e82426a3269d50e5d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 33m 36s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 35s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 54s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 32s
✔️ build-push-container-cifmw-client SUCCESS in 37m 25s
cifmw-molecule-shiftstack FAILURE in 12m 48s

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4c335784df61411f8727d3e10a52bba2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 04s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 22s
cifmw-crc-podified-edpm-baremetal FAILURE in 49m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 09s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 52s
✔️ build-push-container-cifmw-client SUCCESS in 37m 31s
✔️ cifmw-molecule-shiftstack SUCCESS in 14m 23s

For being able to resolve shift-on-stack apps endpoints (routes)
hostnames from RHOSO pods it's required to add the DNS record entry
in then dnsmasq service running on the hypervisor.

It needs to be done after shift-on-stack cluster is installed as
the installer is creating the floating IP for the apps endpoints,
and the FIP is not known in advance.

For that purpose the cifmw_shiftstack_hypervisor param is passed so
the playbook running on the shiftstackclient pod is able to reach
the hypervisor.

This commit also adds the
cifmw_shiftstack_shiftstackclient_incluster_kubeconfig_dir param to
the shiftstack-qa playbook execution so it's able to find the RHOSO
kubeconfig location.
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/211e81376d004d5089ea54fd697e00b0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 26s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 43m 44s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 21s
✔️ build-push-container-cifmw-client SUCCESS in 37m 37s
✔️ cifmw-molecule-shiftstack SUCCESS in 14m 38s

@eurijon
Copy link
Contributor Author

eurijon commented Jan 10, 2025

recheck

@eurijon eurijon requested a review from a team January 10, 2025 08:45
@rlobillo
Copy link
Contributor

/lgtm

Great work!

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bdf4ec8 into openstack-k8s-operators:main Jan 10, 2025
5 checks passed
@eurijon eurijon deleted the hypervisor-param branch January 10, 2025 15:04
@eurijon
Copy link
Contributor Author

eurijon commented Jan 17, 2025

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@eurijon: #2626 failed to apply on top of branch "18.0-fr1":

Applying: Add hypervisor param to shiftstack playbook execution
Using index info to reconstruct a base tree...
M	roles/shiftstack/README.md
M	roles/shiftstack/defaults/main.yml
M	roles/shiftstack/tasks/test_config.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/shiftstack/tasks/test_config.yml
Auto-merging roles/shiftstack/defaults/main.yml
CONFLICT (content): Merge conflict in roles/shiftstack/defaults/main.yml
Auto-merging roles/shiftstack/README.md
CONFLICT (content): Merge conflict in roles/shiftstack/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add hypervisor param to shiftstack playbook execution

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eurijon
Copy link
Contributor Author

eurijon commented Jan 20, 2025

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@eurijon: new pull request created: #2669

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants