[18.0-fr1] Fix interface aggregation in switch_config #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
openshift-ci
bot
added
do-not-merge/work-in-progress
and removed
do-not-merge/work-in-progress
labels
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before the fix when we had and interface already configured like this:
```
description tigon13-enp130s0f2;
enable;
mtu 9192;
unit 0 {
family ethernet-switching {
interface-mode trunk;
vlan {
members [ vlan130 vlan131 vlan132 vlan133 vlan134 vlan135 vlan136 vlan137 vlan138 vlan139 ];
}
}
}
```
And we try to configure aggregation like this:
```
- description: "aggregation"
iface: "ae1323"
iface_mode: "trunk"
vlan: "130-139"
mtu: "9192"
aggr_members:
- "xe-0/0/2"
- "xe-0/0/3"
```
An error like this error was raised:
```
TASK [switch_config : Clear interfaces MTU before adding to ae lines={{ interface_config | from_yaml }}] ****
task path: /home/zuul/src/gitlab.cee.redhat.com/openstack-midstream/podified/source/ci-framework/roles/switch_config/tasks/junos_config.yml:111
ok: [nfv_private_sw04] => changed=false
invocation:
module_args: backup: false
backup_options: null
check_commit: false
comment: configured by junos_config confirm: 0
confirm_commit: false
lines:
- delete interfaces "xe-0/0/2" mtu
- delete interfaces "xe-0/0/2" unit 0
- delete interfaces "xe-0/0/3" mtu
- delete interfaces "xe-0/0/3" unit 0
...
TASK [switch_config : Set aggregation for the interface config={{ interface_config | from_yaml }}, state=replaced] ****
task path: /home/zuul/src/gitlab.cee.redhat.com/openstack-midstream/podified/source/ci-framework/roles/switch_config/tasks/junos_config.yml:125
Tuesday 19 November 2024 10:37:40 -0500 (0:00:02.114) 0:00:50.687 ******
redirecting (type: connection) ansible.builtin.netconf to ansible.netcommon.netconf
redirecting (type: netconf) ansible.builtin.junos to junipernetworks.junos.junos
fatal: [nfv_private_sw04]: FAILED! => changed=false
module_stderr: 'b''error: Setting mtu on ae child device is not allowed\nerror: Setting mtu on ae child device is not allowed\nerror: configuration check-out failed: (statements constraint check failed)'''
module_stdout: ''
msg: |-
MODULE FAILURE
See stdout/stderr for the exact error
```
The error was due to the quotation marks were added to the actual
switch config to be loaded.
After the fix, with the quoation marks removed, we don't hit the
error:
```
TASK [switch_config : Clear interfaces MTU before adding to ae lines={{ interface_config | from_yaml }}] ***
task path: /home/zuul/src/gitlab.cee.redhat.com/openstack-midstream/podified/source/ci-framework/roles/switch_config/tasks/junos_config.yml:111
changed: [nfv_private_sw04] => changed=true invocation:
module_args: backup: false
backup_options: null
check_commit: false
comment: configured by junos_config confirm: 0
confirm_commit: false
lines:
- delete interfaces xe-0/0/2 mtu
- delete interfaces xe-0/0/2 unit 0
- delete interfaces xe-0/0/3 mtu
- delete interfaces xe-0/0/3 unit 0
...
```
And the switch config is properly loaded:
```
description tigon13-enp130s0f2;
enable;
ether-options {
802.3ad ae1323;
}
description tigon13-enp130s0f3;
enable;
ether-options {
802.3ad ae1323;
}
description aggregation;
enable;
mtu 9192;
aggregated-ether-options {
lacp {
active;
}
}
unit 0 {
family ethernet-switching {
interface-mode trunk;
vlan {
members [ vlan130 vlan131 vlan132 vlan133 vlan134 vlan135 vlan136 vlan137 vlan138 vlan139 ];
}
}
}
```
A similar thing happened when we tried to remove the aggregation.
rdiazcam
force-pushed
the
cherry-pick-2554-to-18.0-fr1
branch
from
4083d6c to
1b40a70
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 0296ee8
into
openstack-k8s-operators:18.0-fr1
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2554
/assign rdiazcam