Skip watcher containers for downstream #2515
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6da829e8876f494c8953efbf1aa5ea6f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 06s |
raukadah
force-pushed
the
add_watcher
branch
2 times, most recently
from
5aa3ce2 to
a2e9d91
Compare
Watcher related packages got added in RDO antelope but not available in OSP-18 downstream. openstack-k8s-operators/tcib#215 adds watcher container in tcib. Since downstream tcib jobs install the tcib rpm from main branch so it may break downstream container build and component job. So in order to avoid breakage, we are skip building watcher related containers. Note: It also fixes the exclude conditional to check existence of release key in exclude var to avoid following error: ``` ''dict object'' has no attribute ''master''' ``` Depends-On: openstack-k8s-operators/tcib#215 Signed-off-by: Chandan Kumar <raukadah@gmail.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87cd144a03d9455e8a229680be7f70be ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 07s |
| @@ -55,3 +55,12 @@ cifmw_build_containers_install_from_source: false | |||
| # cifmw_build_containers_dockerfile_labels | |||
| # cifmw_build_containers_extra_config | |||
| # cifmw_build_containers_build_timeout | |||
|
|
|||
| # Note(Chandankumar): Remove it once watcher related packages are available downstream. | |||
| cifmw_build_containers_exclude_containers: | |||
There was a problem hiding this comment.
Rather than defining this temporary list in the role defaults, can it be set in the job variables of the D/S job that calls the role.
There was a problem hiding this comment.
Thank you @lewisdenny for the review, I have proposed a mr downstream to achieve the same.
| @@ -55,3 +55,12 @@ cifmw_build_containers_install_from_source: false | |||
| # cifmw_build_containers_dockerfile_labels | |||
| # cifmw_build_containers_extra_config | |||
| # cifmw_build_containers_build_timeout | |||
|
|
|||
| # Note(Chandankumar): Remove it once watcher related packages are available downstream. | |||
| cifmw_build_containers_exclude_containers: | |||
There was a problem hiding this comment.
cifmw_build_containers_exclude_containers is documented in the README as a list but in fact it's a nested dictionary.
There was a problem hiding this comment.
Good finding, I will update this pull request to address this change and remove watcher skip from here. thank you!
|
This PR is stale because it has been for over 15 days with no activity. |
Watcher related packages got added in RDO antelope but not available in OSP-18 downstream.
openstack-k8s-operators/tcib#215 adds watcher container in tcib. Since downstream tcib jobs install the tcib rpm from main branch so it may break downstream container build and component job.
So in order to avoid breakage, we are skip building watcher related containers.
Note: It also fixes the exclude conditional to check existence of release key in exclude var to avoid following error:
''dict object'' has no attribute ''master'''Depends-On: openstack-k8s-operators/tcib#215