Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untar logs for OCP openstack pods #1941

Closed
wants to merge 1 commit into from

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jun 24, 2024

When running openstack-must-gather tool we are instructing the tool not to untar the whole SOS reports, as they contain way too may files and the file count affects zuul jobs (makes them crash).

This has created a situation where we all need to download and untar files to be able to see the container logs making it harder to have quick looks at logs and sharing URLs to have discussions.

This patch forces the untar of just the logs of the OCP cluster SOS reports. Specifically just the openstack and openstack-operators namespaces, which are the most commonly required.

Additional namespaces can be added to the include or we could just remove it altogether to get all pods.

We are using sosreport-*-UntarWithArg-i.tar.xz instead of *.tar.xz so we don't create empty directories for the EDPM nodes.

Related PR: openstack-k8s-operators/openstack-must-gather#62

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

When running openstack-must-gather tool we are instructing the tool not
to untar the whole SOS reports, as they contain way too may files and
the file count affects zuul jobs (makes them crash).

This has created a situation where we all need to download and untar
files to be able to see the container logs making it harder to have
quick looks at logs and sharing URLs to have discussions.

This patch forces the untar of just the logs of the OCP cluster SOS
reports. Specifically just the openstack and openstack-operators
namespaces, which are the most commonly required.

Additional namespaces can be added to the `include` or we could just
remove it altogether to get all pods.

We are using `sosreport-*-UntarWithArg-i.tar.xz` instead of `*.tar.xz`
so we don't create empty directories for the EDPM nodes.
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rebtoor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft June 24, 2024 14:47
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@Akrog
Copy link
Contributor Author

Akrog commented Jun 26, 2024

After merging openstack-k8s-operators/openstack-must-gather#68 this is no longer necessary to get non-rotated logs.

@Akrog Akrog closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant