Only call configure_object tasks when rgw_enabled is true #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGW related tasks are called by playbooks/ceph.yml only if `cifmw_ceph_daemons_layout.rgw_enabled` is true but the post tasks in the cifmw_cephadm role need the same rule. This patch adds that rule. We didn't discover this until PR 1821 merged. The "Create swift service, user and roles" task in post, only ran when `cifmw_ceph_daemons_layout.rgw_enabled` was true. When PR 1821 merged it added tasks to do the same but they didn't have this condition. Those conditions are removed by this patch as the entire configure_boject tasks file is no longer included by post (and only post includes that file) unless `cifmw_ceph_daemons_layout.rgw_enabled` is true. Jira: https://issues.redhat.com/browse/OSPRH-7889 Signed-off-by: John Fulton <fulton@redhat.com>
|
Thanks for the PR! ❤️ |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 97a8ba1
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGW related tasks are called by playbooks/ceph.yml only if
cifmw_ceph_daemons_layout.rgw_enabledis true but the post tasks in the cifmw_cephadm role need the same rule. This patch adds that rule.We didn't discover this until PR 1821 merged. The "Create swift service, user and roles" task in post, only ran when
cifmw_ceph_daemons_layout.rgw_enabledwas true. When PR 1821 merged it added tasks to do the same but they didn't have this condition. Those conditions are removed by this patch as the entire configure_boject tasks file is no longer included by post (and only post includes that file) unlesscifmw_ceph_daemons_layout.rgw_enabledis true.Jira: https://issues.redhat.com/browse/OSPRH-7889
As a pull request owner and reviewers, I checked that: