Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we don't expose kuebconfig in custom-params.yml #1930

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

cjeanner
Copy link
Contributor

@cjeanner cjeanner commented Jun 21, 2024

This patch also prevents loading all of the CI env in the runtime. This
would expose zuul-params.yml content, which contains unfiltered
parameters, among them the kubeconfig one.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/98837c260ff545f6a9b92f617df909a2

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 15s
cifmw-crc-podified-edpm-baremetal FAILURE in 47m 10s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 36m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 11m 20s
✔️ cifmw-pod-pre-commit SUCCESS in 10m 57s

@cjeanner
Copy link
Contributor Author

recheck

This patch also prevents loading all of the CI env in the runtime. This
would expose zuul-params.yml content, which contains unfiltered
parameters, among them the kubeconfig one.
@cjeanner cjeanner force-pushed the artifacts/no-kubeconfig branch from e2930eb to 5d96465 Compare June 25, 2024 10:30
@cjeanner cjeanner marked this pull request as ready for review June 25, 2024 12:51
@cjeanner
Copy link
Contributor Author

It could make a CI Job reproducer get beyond the nmstate issue faced by the presence of the parameter, toggling the k8s nmstate path.

@cescgina
Copy link
Contributor

/approve this helps in getting past the k8s nmstate reproducer error, but I would like to wait until we got a full green run to merge

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjeanner
Copy link
Contributor Author

/hold

waiting on @cescgina green light.

Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it does what the commit message says it does :) lgtm

@cjeanner
Copy link
Contributor Author

/cancel hold

Let's get it in.

@cescgina
Copy link
Contributor

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit a344c64 into main Jun 28, 2024
6 of 7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the artifacts/no-kubeconfig branch June 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants