-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we don't expose kuebconfig in custom-params.yml #1930
Conversation
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/98837c260ff545f6a9b92f617df909a2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 29m 13s |
recheck |
This patch also prevents loading all of the CI env in the runtime. This would expose zuul-params.yml content, which contains unfiltered parameters, among them the kubeconfig one.
e2930eb
to
5d96465
Compare
It could make a CI Job reproducer get beyond the nmstate issue faced by the presence of the parameter, toggling the k8s nmstate path. |
/approve this helps in getting past the k8s nmstate reproducer error, but I would like to wait until we got a full green run to merge |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cescgina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold waiting on @cescgina green light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, it does what the commit message says it does :) lgtm
/cancel hold Let's get it in. |
/hold cancel |
This patch also prevents loading all of the CI env in the runtime. This
would expose zuul-params.yml content, which contains unfiltered
parameters, among them the kubeconfig one.
As a pull request owner and reviewers, I checked that: