Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devscripts] Allow passing a custom user ignition file for OCP nodes #1923

Closed
wants to merge 1 commit into from

Conversation

pablintino
Copy link
Collaborator

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pablintino. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

combine(_config_data, recursive=true)
}}

- name: Copy the configuration file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we shouldn't allow a list or, even, a directory?

@rebtoor rebtoor self-assigned this Aug 8, 2024
@pablintino
Copy link
Collaborator Author

This functionality is not needed as it was used for troubleshooting an issue and given that we may use other tool to deploy OCP rather than dev-scripts I'm not going to work on this.

@pablintino pablintino closed this Sep 19, 2024
@pablintino pablintino deleted the devscripts/allow-user-ignition-file branch February 4, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants