Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polarion] Merge xmls with junitparser #1918

Merged

Conversation

kopecmartin
Copy link
Contributor

@kopecmartin kopecmartin commented Jun 20, 2024

In case there are multiple xml files that need to be reported
to polarion, we need to merge them before passing them to jump.
Using junitparser even in cases where there is only one xml file
will have these benefits:

  • we don't have to write when conditions
  • the output xml will have the same structure - the content will
    be wrapped in tags whether we have more xml results
    or not - testsuite in junitparser context equals to one xml input.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@github-actions github-actions bot marked this pull request as draft June 20, 2024 12:59
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/80d8eab8c09646b98170eb25305294dd

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 05s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 37s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 22s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 25s
cifmw-pod-pre-commit FAILURE in 8m 00s
✔️ cifmw-molecule-polarion SUCCESS in 1m 29s

@kopecmartin kopecmartin changed the title [polarion] Pre-build arguments for jump [polarion] Merge xmls with junitparser Jun 28, 2024
@kopecmartin kopecmartin force-pushed the multiple_xmls branch 3 times, most recently from 37ca45a to 8710b05 Compare July 2, 2024 06:47
In case there are multiple xml files that need to be reported
to polarion, we need to merge them before passing them to jump.
Using junitparser even in cases where there is only one xml file
will have these benefits:
* we don't have to write when conditions
* the output xml will have the same structure - the content will
be wrapped in <testsuites> tags whether we have more xml results
or not - testsuite in junitparser context equals to one xml input.
@kopecmartin kopecmartin marked this pull request as ready for review July 9, 2024 12:55
@kopecmartin
Copy link
Contributor Author

@tosky
Copy link
Contributor

tosky commented Jul 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 9, 2024
@tosky
Copy link
Contributor

tosky commented Jul 9, 2024

Just please note in the future we will need to readd the loop, for example when a job reports different "phases" of testing.

@raukadah
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7527689 into openstack-k8s-operators:main Jul 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants