Stop hard-coding the framework path #1911
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/308a5d084a28487abf7f6b0c5e208e0b ✔️ noop SUCCESS in 0s |
cjeanner
force-pushed
the
reproducer/ci-framework-path
branch
2 times, most recently
from
ac79ac3 to
6c34366
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1bf90991711041479f760819c25e0c7a ✔️ noop SUCCESS in 0s |
It may happen a user doesn't want to copy the framework in the "standard" location, or that they are using some other tools that clone the framework from another provider. In such case, controller-0 might see the framework cloned in some other tree, meaning all of the generated content. Let's try to be more flexible by using the user provided data, while defaulting to the standard location. The internal _cifmw_reproducer_framework_location fact is available since the very start of the reproducer role call, ensuring we're able to use it even for new features.
cjeanner
force-pushed
the
reproducer/ci-framework-path
branch
from
6c34366 to
8650a85
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It may happen a user doesn't want to copy the framework in the
"standard" location, or that they are using some other tools that clone
the framework from another provider.
In such case, controller-0 might see the framework cloned in some other
tree, meaning all of the generated content.
Let's try to be more flexible by using the user provided data, while
defaulting to the standard location.
The internal _cifmw_reproducer_framework_location fact is available
since the very start of the reproducer role call, ensuring we're able to
use it even for new features.
As a pull request owner and reviewers, I checked that: