Add a new extra variable for holding the update's parameters #1903
Conversation
|
Thanks for the PR! ❤️ |
|
I like the change and idea for new cifmw_update_extras. Just can you rephrase description, please? The aim is to add cifmw_update_extras dict defined at zuul job definition level, instead of using pre-defined inline variables. |
sathlan
changed the title
sathlan
changed the title
Make sure that, when we use downstream repo setup we don't hardcode cifmw_repo_setup_promotion. To that end, and to add more flexibility to the variables that need to be overwritten during update, take the key/value of the `cifmw_update_extras` hash. It should be defined in a job and would look like this: ``` cifmw_update_extras: cifmw_repo_setup_promotion: promotion other_var: value ... ``` That enables the job definition to pass all variables needed for the update job with having new variable name for each override. It also solves the problem of the hardcoded `cifmw_repo_setup_promotion` as now the job has total control over the variables passed.
|
/approve |
|
@sathlan @ciecierski you need to harrass someone from this list https://github.com/openstack-k8s-operators/ci-framework/blob/main/OWNERS to add the /approve here for merge fyi |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marios, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e6406f5
into
openstack-k8s-operators:main
Make sure that, when we use downstream repo setup we don't hardcode
cifmw_repo_setup_promotion.
To that end, and to add more flexibility to the variables that need to
be overwritten during update, take the key/value of the
cifmw_update_extrashash. It should be defined in a job and wouldlook like this:
That enables the job definition to pass all variables needed for the
update job with having new variable name for each override.
It also solves the problem of the hardcoded
cifmw_repo_setup_promotionas now the job has total control over thevariables passed.
Jira: https://issues.redhat.com/browse/OSPRH-7811
As a pull request owner and reviewers, I checked that: