Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set snapshot specs in manila's default type #1902

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Set snapshot specs in manila's default type #1902

merged 1 commit into from
Jun 25, 2024

Conversation

gouthampacha
Copy link
Contributor

@gouthampacha gouthampacha commented Jun 18, 2024 •
edited by rebtoor
Loading

These extra-specs are supported by all share backends
we test currently.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft June 18, 2024 16:26
@rebtoor
Copy link
Contributor

rebtoor commented Jun 18, 2024

@gouthampacha there's already #1901

you can close this one.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2f5c6c3fb319478fba9082c335ccaa6d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 31s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 42s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 31m 07s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 33s

@gouthampacha gouthampacha marked this pull request as ready for review June 18, 2024 20:29
@gouthampacha
Copy link
Contributor Author

@gouthampacha there's already #1901

you can close this one.

Hi @rebtoor - this builds off of that PR, and enables yet another extra-spec for future proofing..

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/cce5e6a9f26c442bb9ee1f1f4bbfbbb3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 32s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 08s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 53s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 32s

@tosky
Copy link
Contributor

tosky commented Jun 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 19, 2024
@rebtoor
Copy link
Contributor

rebtoor commented Jun 19, 2024

recheck

@gouthampacha
Add other snap spec to manila default type
46cc228 
The type could specify support for snapshots
and snapshot clones by default. These capabilities
can be disabled from tempest tests if necessary.
@openshift-ci openshift-ci bot removed the lgtm label Jun 20, 2024
@gouthampacha
Copy link
Contributor Author

@rebtoor @tosky: is this good to go?

@tosky
Copy link
Contributor

tosky commented Jun 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 24, 2024
@tosky
Copy link
Contributor

tosky commented Jun 24, 2024

I was sure this was already merged :/

@raukadah
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fade167 into openstack-k8s-operators:main Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebtoor rebtoor rebtoor left review comments

Assignees

@tosky tosky

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gouthampacha @rebtoor @tosky @raukadah