Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crc resources in centos-9-medium-3x-centos-9-crc-extracted-2-36-0-xxl #1896

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Jun 18, 2024

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gibizer
Copy link
Contributor Author

gibizer commented Jun 21, 2024

We need this resource bump to be able to speed up the upstream test jobs by increasing the openstack service replicas

Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifically this will unblock
openstack-k8s-operators/nova-operator#786

alternitivly we can add a new nodeset but give the time reduction gibi was able to make we will likely want to applied this to other jobs in the future

@@ -309,7 +309,7 @@
- name: compute-2
label: cloud-centos-9-stream-tripleo
- name: crc
label: coreos-crc-extracted-2-36-0-xxl
label: coreos-crc-extracted-2-36-0-3xl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to maintain the name in sync with the labels used, in this case, the nodeset name says: name: centos-9-medium-3x-centos-9-crc-extracted-2-36-0-xxl. I am in favor of creating a new nodeset with a different name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9ad2eed into openstack-k8s-operators:main Jun 25, 2024
5 checks passed
openshift-merge-bot bot pushed a commit to openstack-k8s-operators/nova-operator that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants