Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing var in the README #1895

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Add missing var in the README #1895

merged 1 commit into from
Jun 19, 2024

Conversation

bshewale
Copy link
Contributor

@bshewale bshewale commented Jun 18, 2024

As a pull request owner and reviewers, I checked that:

  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@github-actions github-actions bot marked this pull request as draft June 18, 2024 08:59
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fe0494562ead40a8a38eea0c5534f156

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 43s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 16m 07s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
cifmw-pod-pre-commit FAILURE in 7m 41s
cifmw-molecule-update_containers FAILURE in 4m 45s

@viroel
Copy link
Contributor

viroel commented Jun 18, 2024

I agree with the changes, but the PR title and description needs update.
molecule job is also failing and will require some fixes too.

Copy link
Contributor

@raukadah raukadah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment in the role content change.

roles/update_containers/tasks/main.yml Outdated Show resolved Hide resolved
@frenzyfriday
Copy link
Collaborator

/lgtm

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@viroel viroel marked this pull request as ready for review June 19, 2024 11:18
@openshift-merge-bot openshift-merge-bot bot merged commit b6823fe into main Jun 19, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the update-readme branch June 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants