Switch back public network to be not shared by default #1862
Conversation
|
Thanks for the PR! ❤️ |
Public network created by default by the ci-framework is visible for all tenants to e.g. create Floating IPs from it and that is typically enough for most of our tests. It is also required to not have shared network in the deployment to run tests from the `tempest.api.compute.admin.test_auto_allocate_network` module. Public network was changed to be shared by the commit [1] and it was done because some tests from the whitebox_neutron_tempest_plugin needs to plug directly into the public network and for that network needs to be visible for the project used during the test. But this made tests for the auto_allocate_network to be skipped. So lets by default create public network as not 'shared' to run auto_allocate_network tests in the u/c ci. We may try to modify whitebox_neutron_tempest_plugin tests which require shared network to make them run in slightly different way. Related: #OSPRH-6541
|
/lgtm |
|
@fyanac: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: viroel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 147745c
into
openstack-k8s-operators:main
Public network created by default by the ci-framework is visible for all tenants to e.g. create Floating IPs from it and that is typically enough for most of our tests.
It is also required to not have shared network in the deployment to run tests from the
tempest.api.compute.admin.test_auto_allocate_networkmodule.Public network was changed to be shared by the commit [1] and it was done because some tests from the whitebox_neutron_tempest_plugin needs to plug directly into the public network and for that network needs to be visible for the project used during the test.
But this made tests for the auto_allocate_network to be skipped.
So lets by default create public network as not 'shared' to run auto_allocate_network tests in the u/c ci.
We may try to modify whitebox_neutron_tempest_plugin tests which require shared network to make them run in slightly different way.
Related: #OSPRH-6541
As a pull request owner and reviewers, I checked that: