No group in inventory for managed: false vms.

[hjensas]

If the VM is created as managed: false, it is not added to the inventory. This change ensure no group is created in the inventory as well.

Fixes whitebox_neutron_tempest_plugin which rely on the inventory.

setUpClass (whitebox_neutron_tempest_plugin.tests.scenario.test_broadcast.BroadcastTestVlanTransparency)
--------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/usr/lib/python3.9/site-packages/tempest/test.py", line 191, in setUpClass
    raise value.with_traceback(trace)

      File "/usr/lib/python3.9/site-packages/tempest/test.py", line 184, in setUpClass
    cls.resource_setup()

      File "/usr/lib/python3.9/site-packages/whitebox_neutron_tempest_plugin/tests/scenario/test_broadcast.py", line 73, in resource_setup
    super(BaseBroadcastTest, cls).resource_setup()

      File "/usr/lib/python3.9/site-packages/whitebox_neutron_tempest_plugin/tests/scenario/base.py", line 988, in resource_setup
    cls.discover_nodes()

      File "/usr/lib/python3.9/site-packages/whitebox_neutron_tempest_plugin/tests/scenario/base.py", line 264, in discover_nodes
    cls.nodes = cls.get_podified_nodes_data()

      File "/usr/lib/python3.9/site-packages/whitebox_neutron_tempest_plugin/tests/scenario/base.py", line 244, in get_podified_nodes_data
    hosts_data.update(inventory_data[host_type]['hosts'])

    KeyError: 'ironics'

As a pull request owner and reviewers, I checked that:

• Appropriate testing is done and actually running
• Appropriate documentation exists and/or is up-to-date:
  • README in the role
  • Content of the docs/source is reflecting the changes

[github-actions]

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

[cjeanner]

/approve
makes sense: not managed, not in inventory, so don't create group.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cjeanner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eduolivares]

The patch makes sense to me.
My only doubt is that I have checked the latest unialpha results and the BroadcastTestVlanTransparency tests pass. I haven't seen that "ironic" group.
Perhaps this is from another job or from unialpha+WIP patches?

[hjensas]

The patch makes sense to me. My only doubt is that I have checked the latest unialpha results and the BroadcastTestVlanTransparency tests pass. I haven't seen that "ironic" group. Perhaps this is from another job or from unialpha+WIP patches?

We are making modifications to the job, to enable ironic and running it's scenario tests etc.
See downstream ci-framework/ci-framework-jobs/-/merge_requests/282 - it is adding ironic VMs, these are blank VMs taht we use a virtual baremetal.