Don't run nfs.yml when architecture is defined #1857
Conversation
|
Thanks for the PR! ❤️ |
|
Hi @rlobillo. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@tosky Would you mind to check this one? We are hitting problems deploying va-hci because of this. |
-2. Why would there be a problem? The code has been in place for a while, and if the NFS server is not requested, it should be a noop. |
|
So, it seems the ci-framework code is more complex than I thought and the same condition needs to be repeated more and more times. I'd let the ci-framework maintainers chime in but this may be correct in the end. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/f3dc4aa22c534c5bbf98c8a2028309c8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 03m 05s |
|
recheck |
There was a problem hiding this comment.
Review:
Not OK: this condition should go in this block here:
ci-framework/playbooks/nfs.yml
Lines 20 to 24 in b6823fe
It will ensure the playbook is really skipped.
Context:
We can't really apply a when to import_playbook - it will "just" append that condition to all of the imported tasks, and it might lead to fun situations where the imported play will fail without even being launched...
More over, the end_play meta action applies only to the current play - so if we're running a series of playbook, only the one with that action will end, and the run will just jump to the next play in list.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/3460ea9b96f5476b915854742f2c17ab ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 30s |
|
/retest |
|
@rlobillo: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR is stale because it has been for over 60 days with no activity. |
|
uh, sorry, forgot about this |
|
/ok-to-test |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/23c40d2e7f794fbb84cbded45bdc9f5d ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 25s |
There was a problem hiding this comment.
I agree with @tosky here: #1857 (review)
Is this still problematic for you @rlobillo? If not, drop the change, if it's the case, have a look at my comment to fix the error the jobs are showing.
| @@ -21,6 +21,7 @@ | |||
| - name: End play early if no NFS is needed | |||
| when: | |||
| - not cifmw_edpm_deploy_nfs | default('false') | bool | |||
There was a problem hiding this comment.
@rlobillo care to change this by this?
(not cifmw_edpm_deploy_nfs | default('false') | bool) or (cifmw_architecture_scenario is defined)I know the solution is far from perfect, but it will do the trick for now till we reorganize the code.
|
/close Not needed right now |
As a pull request owner and reviewers, I checked that: