Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uni01alpha - update network-values values.j2 for ironic #1848

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Jun 6, 2024

In PR: openstack-k8s-operators/architecture#211 the DT is updated to configure Ironic so that it can be used beyond running API tempest test cases.

It adds a network bridge "ironic", and this is attached to the ironic service pods, OVN. Also Nova is configured to run a compute pod with the ironic driver.

This PR updates the values.j2 for the uni01alpha job to work with PR#211.
We also need: https://gitlab.cee.redhat.com/ci-framework/ci-framework-jobs/-/merge_requests/282

Not all networks are neccecarily connected to EDPM nodes. Allow generating network-values for networks without netconfig. For example:

    ironic:
      network: "172.20.254.0/24"
      tools:
        metallb:
          ranges:
            - start: 80 end: 90 mtu: 1500

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@github-actions github-actions bot marked this pull request as draft June 6, 2024 23:05
Copy link

github-actions bot commented Jun 6, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@hjensas hjensas force-pushed the uni01alpha-no-netconfig branch from e0041a3 to eec3b46 Compare June 6, 2024 23:05
@hjensas hjensas added the uni01alpha uni01alpha related patches label Jun 7, 2024
@hjensas hjensas marked this pull request as ready for review June 7, 2024 07:11
@hjensas hjensas force-pushed the uni01alpha-no-netconfig branch from eec3b46 to 7eadb0a Compare June 7, 2024 10:22
@hjensas hjensas changed the title uni01alpha - network without netconfig uni01alpha - update network-vvalues values.j2 for ironic Jun 7, 2024
@hjensas hjensas changed the title uni01alpha - update network-vvalues values.j2 for ironic uni01alpha - update network-values values.j2 for ironic Jun 7, 2024
@hjensas hjensas force-pushed the uni01alpha-no-netconfig branch from 7eadb0a to 9bbb2e0 Compare June 7, 2024 10:25
In PR: openstack-k8s-operators/architecture#211
the DT is updated to configure Ironic so that it can be used beyond
running API tempest test.

It adds a network bridge "ironic", and this is attached to the ironic
service pods, OVN. Also Nova is configured to run a compute pod with
the ironic driver.
@hjensas hjensas force-pushed the uni01alpha-no-netconfig branch from 9bbb2e0 to e9eadab Compare June 7, 2024 10:26
@hjensas hjensas marked this pull request as draft June 7, 2024 10:27
@hjensas hjensas marked this pull request as ready for review June 7, 2024 11:41
@arxcruz
Copy link
Contributor

arxcruz commented Jun 7, 2024

/approve
/lgtm

@raukadah
Copy link
Contributor

raukadah commented Jun 7, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arxcruz, raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/dc5d219a1e98490e84cfccd54fdcc5a1

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 41s
podified-multinode-edpm-deployment-crc FAILURE in 1h 34m 53s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 37m 17s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 59s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 23s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 46s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 41s

@raukadah
Copy link
Contributor

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit 21ae461 into openstack-k8s-operators:main Jun 11, 2024
7 checks passed
@hjensas hjensas deleted the uni01alpha-no-netconfig branch June 20, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants