Change iscsid login timeout #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the time to fail an iSCSI login request in our deployments. The default is 8 retries and 15 seconds for each one, so 120 seconds in total. This default timeout is too large for our purposes, because it's greater than the default HAProxy or Apache timeouts. This will create problems creating an image when Glance is using Cinder as a backend and one of the paths to the storage is down. This patch changes the OpenShift cluster default to 3 retries and 5 seconds each (15 seconds in total), which is convenient for testing, as any healthy deployment and backend should be able to login to the backend in that amount of time, and if there is a broken path it will not take 2 minutes to give up, just around 15 seconds. Jira: https://issues.redhat.com/browse/OSPRH-7393 Jira: https://issues.redhat.com/browse/OSPRH-7415
|
Thanks for the PR! ❤️ |
|
recheck |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e444756
into
openstack-k8s-operators:main
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the time to fail an iSCSI login request in our deployments.
The default is 8 retries and 15 seconds for each one, so 120 seconds in total.
This default timeout is too large for our purposes, because it's greater than the default HAProxy or Apache timeouts. This will create problems creating an image when Glance is using Cinder as a backend and one of the paths to the storage is down.
This patch changes the OpenShift cluster default to 3 retries and 5 seconds each (15 seconds in total), which is convenient for testing, as any healthy deployment and backend should be able to login to the backend in that amount of time, and if there is a broken path it will not take 2 minutes to give up, just around 15 seconds.
This PR together with setting the HAProxy timeouts to 60 seconds (openstack-k8s-operators/architecture#275) shoud allow to use multipathing when glance is using cinder as a backend and there are failing paths.
The testing of the change was done using the equivalent LVM+iSCSI sample change in the cinder-operator (openstack-k8s-operators/cinder-operator#397) deploying it with install_yamls.
As a pull request owner and reviewers, I checked that:
Jira: https://issues.redhat.com/browse/OSPRH-7393
Jira: https://issues.redhat.com/browse/OSPRH-7415