Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image pushing to local registry #1843

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

sshnaidm
Copy link
Contributor

@sshnaidm sshnaidm commented Jun 5, 2024

With new podman_image one must specify image in push_args in order to push it to local registry. It doesn't work currently because of podman trying to push it to
"docker.io/library/localhost" taking "localhost" as an image name.
Specify exact image name in push args when registry doens't have any org, only IP.

https://issues.redhat.com/browse/OSPCIX-319

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

With new podman_image one must specify image in push_args
in order to push it to local registry. It doesn't work
currently because of podman trying to push it to
"docker.io/library/localhost" taking "localhost" as an image
name.
Specify exact image name in push args when registry doens't
have any org, only IP.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

Hi @sshnaidm. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot marked this pull request as draft June 5, 2024 15:40
Copy link

github-actions bot commented Jun 5, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@sshnaidm sshnaidm marked this pull request as ready for review June 5, 2024 15:42
@cjeanner
Copy link
Contributor

cjeanner commented Jun 5, 2024

/ok-to-test

@son-vyas
Copy link
Contributor

son-vyas commented Jun 5, 2024

lgtm

@son-vyas
Copy link
Contributor

son-vyas commented Jun 5, 2024

/lgtm

@son-vyas
Copy link
Contributor

son-vyas commented Jun 5, 2024

/approve

1 similar comment
@cjeanner
Copy link
Contributor

cjeanner commented Jun 5, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner, son-vyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 11cb64a into openstack-k8s-operators:main Jun 5, 2024
9 checks passed
@sshnaidm sshnaidm deleted the fiximgs branch June 5, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants