-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image pushing to local registry #1843
Fix image pushing to local registry #1843
Conversation
With new podman_image one must specify image in push_args in order to push it to local registry. It doesn't work currently because of podman trying to push it to "docker.io/library/localhost" taking "localhost" as an image name. Specify exact image name in push args when registry doens't have any org, only IP. Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
Hi @sshnaidm. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for the PR! ❤️ |
/ok-to-test |
lgtm |
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner, son-vyas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11cb64a
into
openstack-k8s-operators:main
With new podman_image one must specify image in push_args in order to push it to local registry. It doesn't work currently because of podman trying to push it to
"docker.io/library/localhost" taking "localhost" as an image name.
Specify exact image name in push args when registry doens't have any org, only IP.
https://issues.redhat.com/browse/OSPCIX-319
As a pull request owner and reviewers, I checked that: