Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmasq - Enable Router Advertisements if v6 range #1839

Merged

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Jun 5, 2024

Add a check in a networks 'ranges' - if 'start_v6' is defined in any range add 'enable-ra' to the dnsmasq config.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@hjensas hjensas requested a review from cjeanner June 5, 2024 11:35
@github-actions github-actions bot marked this pull request as draft June 5, 2024 11:35
Copy link

github-actions bot commented Jun 5, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Add a check in a networks 'ranges' - if 'start_v6' is defined
in any range add 'enable-ra' to the dnsmasq config.
@hjensas hjensas force-pushed the dnsmasq-enable-ra branch from 8215b84 to 17276fa Compare June 5, 2024 11:38
@hjensas hjensas marked this pull request as ready for review June 5, 2024 12:27
@hjensas hjensas added the ipv6 label Jun 5, 2024
@cjeanner
Copy link
Contributor

cjeanner commented Jun 5, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d881e09 into openstack-k8s-operators:main Jun 5, 2024
9 of 10 checks passed
@hjensas hjensas deleted the dnsmasq-enable-ra branch June 20, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants