[shiftstack] Allow custom storage class

[psathyan]

This change fixes the issues identified during unit testing with compute nodes.

• Allow custom storage class
• suffix Name to subnet

Without the suffix, openstackdataplanenodeset fails to apply due the need of network subnet name.

As a pull request owner and reviewers, I checked that:

• Appropriate testing is done and actually running

Testing results

[zuul@controller-0 ~]$ oc get bmh -n openshift-machine-api
NAME                 STATE                    CONSUMER                   ONLINE   ERROR   AGE
compute-0            provisioning             compute-nodes              true             115m
osasinfra-master-0   externally provisioned   osasinfra-7vkv8-master-0   true             42h
osasinfra-master-1   externally provisioned   osasinfra-7vkv8-master-1   true             42h
osasinfra-master-2   externally provisioned   osasinfra-7vkv8-master-2   true             42h
[zuul@controller-0 ~]$ oc get osdpns
NAME            STATUS   MESSAGE
ceph-nodes      True     NodeSet Ready
compute-nodes   False    NodeSetBaremetalProvisionReady not yet ready
[zuul@controller-0 ~]$ oc get osdpd
NAME          NODESETS         STATUS   MESSAGE
ceph-deploy   ["ceph-nodes"]   True     Setup complete

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e7cbeccfe1f646df89d8c11d26ea7df4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 03s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 13s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test FAILURE in 5m 04s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 4m 38s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 34s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 41s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 35s

[queria]

/recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1e6629ca6c3b45bf8e18b455feab949b

❌ openstack-k8s-operators-content-provider MERGE_CONFLICT in 1m 09s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 34s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 5m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 21s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 09s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 20s

[morucci]

recheck

[softwarefactory-project-zuul]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Unable to update github.com/openstack-k8s-operators/ci-framework

[morucci]

recheck

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4c6b41688a5d480f835d1c591a62922b

✔️ openstack-k8s-operators-content-provider SUCCESS in 41m 55s
❌ podified-multinode-edpm-deployment-crc FAILURE in 24m 09s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 18m 11s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 26s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 5m 19s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 43s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 20s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 6m 25s

[pablintino]

ShiftOnStack seems to be working, and despite the change looks lgtm we don't have the time and resources to test both implicit changes (storage class and field renames) right now, neither during the past months.