Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhol_crc]Set default version of CRC deployed #1809

Conversation

lewisdenny
Copy link
Collaborator

@lewisdenny lewisdenny commented Jun 3, 2024

This default is used when deploying the reproducer layout. We should deploy the version we default to across CI and allow overriding to deploy latest rather than defaulting to latest.

Jira: https://issues.redhat.com/browse/OSPRH-6871

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link

github-actions bot commented Jun 3, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft June 3, 2024 04:39
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b6cbcdba150445b5ad670d9d1d721526

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 52s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 17s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 02s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 11s
✔️ cifmw-baremetal-nested-crc SUCCESS in 1h 02m 01s
cifmw-molecule-rhol_crc FAILURE in 11m 53s

This default is used when deploying the reproducer layout. We should deploy the version we default to across CI and allow overriding to deploy latest rather than defaulting to latest.
@lewisdenny lewisdenny force-pushed the set_reproducer_crc_version branch from ce496ef to fc31dc7 Compare June 3, 2024 20:54
@lewisdenny lewisdenny marked this pull request as ready for review June 3, 2024 20:55
@cjeanner
Copy link
Contributor

cjeanner commented Jun 3, 2024

/approve

I'm dreaming about a way to get the actual release running in CI when doing a reproducer run... That's probably for later.

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lewisdenny
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here
Needs approval from an approver in each of these files:

yeah I'm with you mate, one for the back log. Wouldn't be too hard but more than I have time for now sadly.

@openshift-ci openshift-ci bot added the lgtm label Jun 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 56207ad into openstack-k8s-operators:main Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants