Use the cifmw venv to run VA validations #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
pablintino
force-pushed
the
validate-architecture/use-cifmw-venv-to-run-validation-playbook
branch
from
19b6c5a to
9b8c9cf
Compare
In zuul VA validation jobs we are installing via setup_molecule the cifmw collection and dependencies but we are using the zuul executor venv, leading to missing deps like custom filters or jmespath missing.
pablintino
force-pushed
the
validate-architecture/use-cifmw-venv-to-run-validation-playbook
branch
from
9b8c9cf to
374313a
Compare
rebtoor
approved these changes
May 31, 2024
psathyan
approved these changes
Jun 1, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
deleted the
validate-architecture/use-cifmw-venv-to-run-validation-playbook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In zuul VA validation jobs we are installing via setup_molecule the cifmw collection and dependencies but we are using the zuul executor venv, leading to missing deps like custom filters or jmespath missing.
As a pull request owner and reviewers, I checked that: