polarion: update the usage of cifmw_polarion_update_testcases #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cifmw_polarion_update_testcases is named after a parameter of a tool and it doesn't match its behavior: it is about adding missing test cases when they don't exist. But the "normal" workflow is to pre-populate the test cases and only update (for real) their results, so that variable should almost never be enabled. Also, remove the check about the variable being enabled, as its only usage is guarded by a default() filter.
|
Thanks for the PR! ❤️ |
jparoly
approved these changes
May 31, 2024
kopecmartin
reviewed
Jun 3, 2024
|
Internally tested, nothing seems to explode, move to "ready for review" |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit aa122a3
into
openstack-k8s-operators:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cifmw_polarion_update_testcases is named after a parameter of a tool and it doesn't match its behavior: it is about adding missing test cases when they don't exist. But the "normal" workflow is to pre-populate the test cases and only update (for real) their results, so that variable should almost never be enabled.
Also, remove the check about the variable being enabled, as its only usage is guarded by a default() filter.
As a pull request owner and reviewers, I checked that: