-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tasks to serve gating repo over content provider #1798
Conversation
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9d003d4f1f1f4f6bb08ce392a336171a ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 11s |
22e7b20
to
70886b3
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/8da4a75daa614e8eb79332254e0d3a8c ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 28s |
8ebe566
to
ad36e6f
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/9e465d9a22bb46c88bb10a00987016a7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 55s |
rrecheck |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/02afce75074548b38e1cc653fa8649c5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 40s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable, just a thought about the pids search but maybe unnecessary
|
||
- name: Getting process IDs of the python http server | ||
community.general.pids: | ||
pattern: "python -m http.server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't played with that before, but wondering can we make it more specific like include the port number here, so we can be sure to only kill the one we are interested in?
pattern: "python -m http.server 8766"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and clicking approve
just a thought inline and really up to you. Maybe overkill because we probably won't ever change 8766, but, maybe a bit cleaner for future generations of engineers to maintain ;)
@@ -51,6 +51,9 @@ | |||
priority=1 | |||
dest: "{{ cifmw_bop_gating_repo_dest }}/gating.repo" | |||
|
|||
- name: Serve gating repo | |||
ansible.builtin.import_tasks: serve_gating_repo.yml | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future maintenance we could consider adding vars: to this import so we can add 8766 as param avoiding repetition there in serve_gating_repo.yaml
- name: Serve gating repo
ansible.builtin.import_tasks: serve_gating_repo.yml
vars:
gating_port: 8766
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marios for the suggestion!. Sounds good.
|
||
- name: Getting process IDs of the python http server | ||
community.general.pids: | ||
pattern: "python -m http.server 8766" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be
"python -m http.server {{ gating_port }}"
with my other comment
The build_openstack_packages role will build the packages, creates the gating repo and then serves the gating repo over simple http server. The repo-setup role will run on the dependent job and populate gating repo on the controller. Gating repo will be used to pull build rpms from content provider. Signed-off-by: Chandan Kumar <raukadah@gmail.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The build_openstack_packages role will build the packages, creates the gating repo and then serves the gating repo over simple http server.
The repo-setup role will run on the dependent job and populate gating repo on the controller. Gating repo will be used to pull build rpms from content provider.
Tested here: os-net-config/os-net-config#20 (comment)
As a pull request owner and reviewers, I checked that: