Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks to serve gating repo over content provider #1798

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented May 31, 2024

The build_openstack_packages role will build the packages, creates the gating repo and then serves the gating repo over simple http server.

The repo-setup role will run on the dependent job and populate gating repo on the controller. Gating repo will be used to pull build rpms from content provider.

Tested here: os-net-config/os-net-config#20 (comment)

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented May 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9d003d4f1f1f4f6bb08ce392a336171a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 11s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 49s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 11s
cifmw-data-plane-adoption-osp-17-to-extracted-crc RETRY_LIMIT in 26m 43s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 00s
cifmw-pod-pre-commit FAILURE in 7m 46s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 12m 20s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 33s

@raukadah raukadah force-pushed the bop_serve_repos branch 3 times, most recently from 22e7b20 to 70886b3 Compare May 31, 2024 14:45
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8da4a75daa614e8eb79332254e0d3a8c

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 22m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 30s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 32s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 39m 44s
✔️ noop SUCCESS in 0s
cifmw-pod-ansible-test FAILURE in 5m 26s
cifmw-pod-pre-commit FAILURE in 9m 33s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 11m 21s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 00s

@raukadah raukadah force-pushed the bop_serve_repos branch 3 times, most recently from 8ebe566 to ad36e6f Compare June 4, 2024 04:45
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9e465d9a22bb46c88bb10a00987016a7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 23s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 56s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 56m 01s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 14s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 25s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 11m 44s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 43s

@raukadah raukadah marked this pull request as ready for review June 4, 2024 07:58
@raukadah
Copy link
Contributor Author

raukadah commented Jun 4, 2024

rrecheck

@raukadah
Copy link
Contributor Author

raukadah commented Jun 4, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/02afce75074548b38e1cc653fa8649c5

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 19s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 53s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 56m 13s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 47s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 40s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 10m 30s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 53s

Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable, just a thought about the pids search but maybe unnecessary


- name: Getting process IDs of the python http server
community.general.pids:
pattern: "python -m http.server"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't played with that before, but wondering can we make it more specific like include the port number here, so we can be sure to only kill the one we are interested in?

pattern: "python -m http.server 8766"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jun 6, 2024
Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and clicking approve

just a thought inline and really up to you. Maybe overkill because we probably won't ever change 8766, but, maybe a bit cleaner for future generations of engineers to maintain ;)

@@ -51,6 +51,9 @@
priority=1
dest: "{{ cifmw_bop_gating_repo_dest }}/gating.repo"

- name: Serve gating repo
ansible.builtin.import_tasks: serve_gating_repo.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future maintenance we could consider adding vars: to this import so we can add 8766 as param avoiding repetition there in serve_gating_repo.yaml

- name: Serve gating repo
  ansible.builtin.import_tasks: serve_gating_repo.yml
  vars:
      gating_port: 8766

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marios for the suggestion!. Sounds good.


- name: Getting process IDs of the python http server
community.general.pids:
pattern: "python -m http.server 8766"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be

"python -m http.server {{ gating_port }}"

with my other comment

@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
The build_openstack_packages role will build the packages, creates
the gating repo and then serves the gating repo over simple http
server.

The repo-setup role will run on the dependent job and populate
gating repo on the controller. Gating repo will be used to pull build
rpms from content provider.

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
@rebtoor
Copy link
Contributor

rebtoor commented Jun 6, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2412d35 into main Jun 6, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the bop_serve_repos branch June 6, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants