Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'https://' to cifmw_ceph_rgw_keystone_ep #1795

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add missing 'https://' to cifmw_ceph_rgw_keystone_ep #1795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/cifmw_cephadm/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ cifmw_cephadm_pacific_filter: "16.*"
# The path of the rendered rgw spec file
cifmw_ceph_rgw_spec_path: /tmp/ceph_rgw.yml
cifmw_ceph_mds_spec_path: /tmp/ceph_mds.yml
cifmw_ceph_rgw_keystone_ep: "keystone-internal.openstack.svc:5000"
cifmw_ceph_rgw_keystone_ep: "https://keystone-internal.openstack.svc:5000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https here is added to the internal keystone endpoint: if tls is not enabled at Pod level (podLevel: true in the ctlplane) but the ingress is configured as an edge router [1] this will fail.
While I think https should be the default, we should isolate the prefix in it's own variable.
I'm ok to follow up on that, but I would try something like:

cifmw_ceph_rgw_keystone_ep: "{{ cifmw_ceph_rgw_keystone_urischeme | default("https") }}:keystone-internal.openstack.svc:5000"

so we can make it configurable w/o introducing extra complexity.

[1] https://www.redhat.com/architect/encryption-secure-routes-openshift

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, considering you can override the entire variable, my comment is not a blocker for the patch, more of a consideration.
So let me know if you want to keep it as it is and I can approve.

cifmw_ceph_rgw_keystone_psw: 12345678
cifmw_ceph_rgw_keystone_user: "swift"
cifmw_ceph_rgw_config:
Expand Down