Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new nodeset of 2.36 (OCP 4.14) #1764

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

bshewale
Copy link
Contributor

@bshewale bshewale commented May 27, 2024

Created new nodeset of CRC 2.36 (OCP 4.14)

Jira: https://issues.redhat.com/browse/OSPRH-6868

  • Tick to trick the bot

Copy link

Zuul encountered a syntax error while parsing its configuration in the
repo openstack-k8s-operators/ci-framework on branch main. The error
was:

Nodeset 4x-centos-9-medium already defined

The error appears in the following nodeset stanza:

nodeset:
name: 4x-centos-9-medium
nodes:
- name: controller
label: cloud-centos-9-stream-tripleo-medium
- name: compute-0
label: cloud-centos-9-stream-tripleo-medium
- name: compute-1
label: cloud-centos-9-stream-tripleo-medium
- name: crc
label: cloud-centos-9-stream-tripleo-medium
groups:
- name: computes
nodes:
- compute-0
- compute-1
- name: ocps
nodes:
- crc

in "openstack-k8s-operators/ci-framework/zuul.d/nodeset.yaml@main", line 302, column 3

@github-actions github-actions bot marked this pull request as draft May 27, 2024 10:39
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bshewale I verified all the new CRC node labels exist at [1]

Just some nits on naming.

[1] https://softwarefactory-project.io/zuul/t/rdoproject.org/labels

zuul.d/nodeset.yaml Show resolved Hide resolved
zuul.d/nodeset.yaml Outdated Show resolved Hide resolved
zuul.d/nodeset.yaml Outdated Show resolved Hide resolved
zuul.d/nodeset.yaml Outdated Show resolved Hide resolved
zuul.d/nodeset.yaml Outdated Show resolved Hide resolved
@bshewale bshewale force-pushed the create-node-for-2-36 branch from b6575f4 to 4803c70 Compare May 28, 2024 07:52
@bshewale bshewale marked this pull request as ready for review May 28, 2024 07:54
@bshewale bshewale force-pushed the create-node-for-2-36 branch from 4803c70 to 53f0ecf Compare May 28, 2024 07:54
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0203fbc2da014e02be6da204a3345be4

openstack-k8s-operators-content-provider FAILURE in 9m 45s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 58s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 42s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 54s

@lewisdenny
Copy link
Collaborator

recheck

@lewisdenny
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
@cjeanner
Copy link
Contributor

cjeanner commented Jun 3, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit af8702b into main Jun 3, 2024
6 of 7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the create-node-for-2-36 branch June 3, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants