Fix sushy_emulator integration in reproducer #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A series of assumptions were made and lead to some issues with the way the reproducer works. Mostly, it can happen a hypervisor doesn't have the "zuul" user (for example a home lab), leading to issues when facts such as `ansible_user_id`, `ansible_user_dir` and related are used in conjuction with `delegate_to`. This patch allows the reproducer to properly works with the sushy_emulator integration, and fixes some of those assumptions. It also ensure the molecule tests for reproducer role is triggered uppon podman and sushy_emulator role modifications.
|
Skipping CI for Draft Pull Request. |
cjeanner
requested review from
lewisdenny
and removed request for
rlandy and
bshewale
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 5, 2024
It's a followup of openstack-k8s-operators#1753
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 5, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the '/home' gets resolved as '/var/home' by realpath, leading to incorrect path in remote machine. Without 'realpath', we end up with the '..' in the patch which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not 'zuul' (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 5, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the '/home' gets resolved as '/var/home' by realpath, leading to incorrect path in remote machine. Without 'realpath', we end up with the '..' in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not 'zuul' (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 5, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
4 tasks
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 5, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 5, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 6, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
jcapiitao
added a commit
to jcapiitao/ci-framework
that referenced
this pull request
Jun 7, 2024
It's a followup of openstack-k8s-operators#1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jun 16, 2024
It's a followup of #1753. We get rid of realpath filter which resolves the path using the controller's filesystem [1]. When the filesystems don't match between the controller and the remote machine, we might hit somme issues. For instance, when running controller on a Fedora CoreOS system, the `/home` gets resolved as `/var/home` by realpath, leading to incorrect path in remote machine. Without `realpath`, we end up with the `..` in the path which is a bit uggly but we keep the consistency. Also, we set the hypervisor ansible user used as the emulator libvirt user in order to have a more dynamic configuration, otherwise it fails by default if hypervisor ansible user is not `zuul` (i.e default user). [1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/realpath_filter.html#synopsis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of assumptions were made and lead to some issues with the way
the reproducer works.
Mostly, it can happen a hypervisor doesn't have the "zuul" user (for
example a home lab), leading to issues when facts such as
ansible_user_id,ansible_user_dirand related are used in conjuctionwith
delegate_to.This patch allows the reproducer to properly works with the
sushy_emulator integration, and fixes some of those assumptions.
It also ensure the molecule tests for reproducer role is triggered uppon
podman and sushy_emulator role modifications.
As a pull request owner and reviewers, I checked that: