Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducer scenario for PIDONE VA #1752

Merged

Conversation

lmiccini
Copy link
Contributor

@lmiccini lmiccini commented May 23, 2024

This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4).

See openstack-k8s-operators/architecture#245

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

@openshift-ci openshift-ci bot requested review from queria and viroel May 23, 2024 05:25
@github-actions github-actions bot marked this pull request as draft May 23, 2024 05:25
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@lmiccini lmiccini force-pushed the va_pidone branch 3 times, most recently from dc54780 to 294bb41 Compare May 23, 2024 11:53
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

Additionally, we need to expand networking-env-definition.yml to
include additional workers.

See openstack-k8s-operators/architecture#245
@abays
Copy link
Contributor

abays commented May 28, 2024

Since the do-not-merge/work-in-progress label was removed, I'm going to remove this PR from Draft state. It might be preventing the depends-on in openstack-k8s-operators/architecture#245 from working properly.

@abays abays marked this pull request as ready for review May 28, 2024 17:42
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 404c7b4 into openstack-k8s-operators:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants