Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we clean all the generated files as well #1750

Merged
merged 1 commit into from
May 23, 2024

Conversation

cjeanner
Copy link
Contributor

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented May 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cjeanner cjeanner force-pushed the libvirt_manager/clean-files branch from b437a83 to 367eae2 Compare May 22, 2024 18:38
@cjeanner cjeanner marked this pull request as ready for review May 22, 2024 19:38
@openshift-ci openshift-ci bot requested review from lewisdenny and pojadhav May 22, 2024 19:38
@cescgina
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pablintino
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 533ee13 into main May 23, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the libvirt_manager/clean-files branch May 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants